chore(dev): use lazy variable for CONTAINER_TOOL detection#25523
Merged
Conversation
thomasqueirozb
added
the
no-changelog
thomasqueirozb
marked this pull request as ready for review
May 29, 2026 14:53
thomasqueirozb
enabled auto-merge
May 29, 2026 14:53
pront
approved these changes
May 29, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4e8f2669d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
CONTAINER_TOOLauto-detection used$(shell ...)insideifeqblocks, which GNU Make evaluates eagerly at parse time — meaningdocker versionandpodman versionran on everymakeinvocation, including unrelated targets likemake check-clippy. If Docker is broken or hangs, it blocks allmakecommands.Replaced with a single lazy
?=variable whose shell expansion only runs when$(CONTAINER_TOOL)is actually referenced in a recipe (currently onlycross-image-%).Also removed the unused
check-container-tooltarget.Vector configuration
NA
How did you test this PR?
Ran
make check-clippylocally with Docker in a broken state which hangs on alldockercommands.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
NA