Add params prop for not-found page [have questions] - #59948
Closed
alexdln wants to merge 1 commit into
Closed
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
2 similar comments
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
alexdln
marked this pull request as ready for review
January 2, 2024 18:57
alexdln
requested review from
feedthejim,
huozhi,
ijjk,
shuding,
timneutkens,
wyattjoh and
ztanner
as code owners
January 2, 2024 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a feature
What?
Passing parameters for not-found errors
Why?
Dynamic 404 errors are needed. The most vivid example is a localized error within the [lang] directory (which is suggested in the next.js documentation for internationalization).
In any case, the 404 page in this directory should be localized (for example, if a user from Germany stumbles upon a deleted post or FAQ).
Currently, to achieve this, either all translations and data need to be passed to the client or the language needs to be determined from the headers (after adding it to the middleware), thus making the page dynamic.
How?
I simply pass the parameters of the current segment to the NotFound component. It worked as expected during manual tests.
Questions
Can you explain why this was not done initially?
If this solution is acceptable, I will write tests and finalize the pull request. Otherwise, please describe the cases, and I might be able to come up with a solution.
Fixes #43179