Skip to content

reliability of the release action - #66637

Merged
sokra merged 2 commits into
canaryfrom
sokra/release-action
Jun 7, 2024
Merged

reliability of the release action#66637
sokra merged 2 commits into
canaryfrom
sokra/release-action

Conversation

@sokra

@sokra sokra commented Jun 7, 2024

Copy link
Copy Markdown
Member

What?

Why?

On failure we might want to re-run the whole action or publish a new release without changes

@sokra
sokra requested review from a team as code owners June 7, 2024 11:43
@sokra
sokra requested review from delbaoliveira and manovotny and removed request for a team June 7, 2024 11:43
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jun 7, 2024
@ijjk

ijjk commented Jun 7, 2024

Copy link
Copy Markdown
Member

Failing test suites

Commit: 7e26cd7

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts (PPR)

  • app dir - navigation > browser back to a revalidated page > should load the page
Expand output

● app dir - navigation › browser back to a revalidated page › should load the page

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#submit-button')

  419 |     return this.chain(() => {
  420 |       return page
> 421 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  422 |         .then(async (el) => {
  423 |           // it seems selenium waits longer and tests rely on this behavior
  424 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:421:10)

Read more about building and testing Next.js in contributing.md.

@sokra
sokra merged commit 6820820 into canary Jun 7, 2024
@sokra
sokra deleted the sokra/release-action branch June 7, 2024 12:50
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants