fix not found stuck when navigating back with search params - #88802
Open
lpalmes wants to merge 3 commits into
Open
fix not found stuck when navigating back with search params#88802lpalmes wants to merge 3 commits into
lpalmes wants to merge 3 commits into
Conversation
…_with_search_params
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
…_with_search_params
timneutkens
approved these changes
Feb 2, 2026
timneutkens
left a comment
timneutkens
left a comment
Contributor
There was a problem hiding this comment.
Change looks good to me. @acdlite can you give it a review too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Not found is stuck after triggering a notFound using search params, back navigation doesn't restore the previous page.
Reproduction case: https://repro-not-found-stuck-on-search-par.vercel.app/
Source Code: https://github.com/lpalmes/repro-not-found-stuck-on-search-params-back-navigation
Steps:
/notFound(), for example/?page=12Try with the
/non-existentbutton and it worksFix
Take into account the search params in
HTTPAccessFallbackErrorBoundaryto reset the boundary.Added e2e test to avoid the regression.