Update image.mdx with note on 'sizes' property - #89470
Closed
karlkeefer wants to merge 1 commit into
Closed
Conversation
Added note about the required 'sizes' property for responsive resizing.
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added note about the required
sizesproperty for responsive resizing.I was extremely surprised to discover responsive resizing doesn't happen without this property given the way the docs start.
The docs currently describe the component with this:
Followed by a code example that doesn't use
sizesproperty and therefore doesn't get automatically optimized (other than 2x version).I could also get behind including a
sizesprop in the code example to at least invite people to read that detail buried in the docs. I might even argue that the default should be100vwwith responsive resizing, but that's probably a major breaking change for folks who expect the existing behavior.