Skip to content

[ts-plugin] Preserve TypeScript quick info metadata#95863

Merged
timneutkens merged 1 commit into
canaryfrom
jiwon/ts-plugin-preserve-quick-info
Jul 24, 2026
Merged

[ts-plugin] Preserve TypeScript quick info metadata#95863
timneutkens merged 1 commit into
canaryfrom
jiwon/ts-plugin-preserve-quick-info

Conversation

@devjiwonchoi

@devjiwonchoi devjiwonchoi commented Jul 16, 2026

Copy link
Copy Markdown
Member

Why?

VS Code passes a maximum hover length and verbosity level to TypeScript's getQuickInfoAtPosition API when a user expands a hover. The Next.js TypeScript plugin intercepted that call and forwarded the file name and position, dropping the remaining arguments. The plugin also replaced TypeScript's QuickInfo object when it added config documentation, which discarded native fields such as canIncreaseVerbosityLevel. As a result, hovers for Next.js config exports could not expand and lost native type information.

This supersedes #86290 with a narrower behavior change. The plugin preserves native QuickInfo when it adds documentation to valid config values and config identifiers. Invalid config values keep the existing synthesized override, and hovers inside function initializers retain TypeScript's existing behavior.

x-ref: microsoft/vscode#232685 (comment)

Before After
Config hover without expandable metadata Config hover with expandable metadata

How?

The plugin forwards all QuickInfo arguments to TypeScript and passes the native result into the config hover rules. For valid config values and identifiers, those rules copy the native QuickInfo fields and append the Next.js documentation. They synthesize the existing fallback when TypeScript returns no QuickInfo.

Focused tests cover argument forwarding, metadata preservation, missing native QuickInfo, invalid config values, and function config boundaries.

Test plan

Open a minimal Next.js app in Cursor with workspace TypeScript 6.0.2 and the package built from this PR. Hover export const metadata: Metadata, then select the expansion control. The hover expands from Metadata to its full property type while the Next.js config documentation and link remain visible.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 51ba8b2

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Stats from current PR

🟢 1 improvement

Metric Canary PR Change Trend
Webpack Cold (First Request) 3.389s 3.264s 🟢 125ms (-4%) ▁▁▁▂▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 1.115s 1.114s ▁▂█▂▂
Cold (Ready in log) 1.101s 1.082s ▁▁█▂▁
Cold (First Request) 1.845s 1.813s ▁▁█▃▁
Warm (Listen) 1.116s 1.115s ▁▂█▂▂
Warm (Ready in log) 1.076s 1.089s ▁▁█▂▁
Warm (First Request) 829ms 840ms ▁▁█▃▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 813ms 761ms ▁▁▁▂▂
Cold (Ready in log) 792ms 761ms ▁▁▁▂▂
Cold (First Request) 3.389s 3.264s 🟢 125ms (-4%) ▁▁▁▂▁
Warm (Listen) 761ms 762ms ▁▂▁▁▂
Warm (Ready in log) 765ms 768ms ▁▁▁▁▁
Warm (First Request) 3.338s 3.295s ▁▁▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 7.515s 7.547s ▁▁█▄▂
Cached Build 7.762s 7.668s ▁▂█▄▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 24.402s 24.507s ▁▁▁▂▁
Cached Build 25.160s 24.673s ▁▂▁▂▁
node_modules Size 516 MB 516 MB ▁████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
01ej5hausrj59.js gzip 155 B N/A -
03gmyxr7dukvs.js gzip 10.3 kB N/A -
040t1q17lo593.js gzip 8.77 kB N/A -
0bb0vtp8dwsez.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0l0sr6gau5xjn.js gzip 3.53 kB N/A -
0nxqz3q165m2l.js gzip 220 B N/A -
0qr-1tnb7_hg5.js gzip 5.72 kB N/A -
0uilzvklme4ea.js gzip 8.76 kB N/A -
0z0y83mfx-l-h.js gzip 10 kB N/A -
1_-g_r52k540c.js gzip 7.4 kB N/A -
11onfdpbudeec.js gzip 154 B N/A -
15ok8ydf274z0.js gzip 10.6 kB N/A -
16cqqcigykfea.js gzip 13.6 kB N/A -
17h18zxt1915l.js gzip 1.46 kB N/A -
19vifh5iqephk.js gzip 158 B N/A -
1cjyeh2th3h3g.js gzip 71 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1fq1h7dxad4cv.js gzip 9.44 kB N/A -
1fym-adbk_69_.js gzip 13.1 kB N/A -
1gav7nfh4y8ln.js gzip 8.76 kB N/A -
1mbayfijnc4mr.js gzip 154 B N/A -
1o34vh44ndvtu.js gzip 13.2 kB N/A -
1ufl-_jc-p-jv.js gzip 65.6 kB N/A -
23ahh8aj11eib.js gzip 152 B N/A -
24s61_7wt5wma.js gzip 153 B N/A -
28zvm2eil07rs.js gzip 155 B N/A -
29fgq-30c4we5.js gzip 158 B N/A -
2g72182uckjva.js gzip 154 B N/A -
2ienk5oyaycls.js gzip 155 B N/A -
2ls1p246l5h9x.js gzip 166 B N/A -
2rypqffktcxqh.js gzip 8.69 kB N/A -
2uqsizxtehgqf.js gzip 8.79 kB N/A -
2vzktdqwbijqc.js gzip 8.74 kB N/A -
2wcar9zudlttv.js gzip 44.9 kB N/A -
36-aonvjl8-q9.js gzip 154 B N/A -
3c244akvx_-be.js gzip 8.74 kB N/A -
3dmlemitx3ef3.js gzip 2.29 kB N/A -
3yjhj-iz0bdp4.js gzip 151 B N/A -
4237vdj6eyslt.js gzip 8.7 kB N/A -
turbopack-0g..lah7.js gzip 3.78 kB N/A -
turbopack-0j..ua2_.js gzip 3.77 kB N/A -
turbopack-0m..4-7v.js gzip 3.78 kB N/A -
turbopack-0s..7xkv.js gzip 3.77 kB N/A -
turbopack-14..p97a.js gzip 3.77 kB N/A -
turbopack-1f..7d2q.js gzip 3.77 kB N/A -
turbopack-1m..pdz-.js gzip 3.78 kB N/A -
turbopack-28..g4wv.js gzip 3.78 kB N/A -
turbopack-2c..8hif.js gzip 3.79 kB N/A -
turbopack-2h..bwrl.js gzip 3.77 kB N/A -
turbopack-33..nc2f.js gzip 3.77 kB N/A -
turbopack-3b..2w-8.js gzip 3.77 kB N/A -
turbopack-3f..yfnt.js gzip 3.77 kB N/A -
turbopack-3s..zbad.js gzip 3.76 kB N/A -
0_brf1o8xtfgw.js gzip N/A 156 B -
00tc16j5-eos9.js gzip N/A 1.46 kB -
0gaw1gmpwuwkn.js gzip N/A 8.8 kB -
0lfd6n4hnvfus.js gzip N/A 156 B -
0mwo2e6a43qd6.js gzip N/A 154 B -
0oxxm8ra6x40w.js gzip N/A 155 B -
12zyjjmq4oad1.js gzip N/A 5.72 kB -
1b_5lm2rb0cxg.js gzip N/A 65.6 kB -
1k9cc4-gpa2cx.js gzip N/A 13.1 kB -
1kfiwrcr725kl.js gzip N/A 13.2 kB -
1n59uogejo81s.js gzip N/A 10.3 kB -
1npei3hlexdv3.js gzip N/A 9.99 kB -
1q-0qyccjh4q3.js gzip N/A 158 B -
1ssuiwj_rnpc5.js gzip N/A 8.77 kB -
2-phc9obd3nyd.js gzip N/A 8.77 kB -
20z9kb96_57f4.js gzip N/A 164 B -
24utq57r3l1cw.js gzip N/A 8.7 kB -
29tie9lu2une4.js gzip N/A 71 kB -
2aw0kxkhyra0_.js gzip N/A 153 B -
2eemzo7z71a10.js gzip N/A 154 B -
2fhjq6ek3srmr.js gzip N/A 8.69 kB -
2g0t7upz_v-hf.js gzip N/A 10.6 kB -
2ia9qqy99aie9.js gzip N/A 13.6 kB -
2n5fp99a5xt9s.js gzip N/A 7.4 kB -
2oza28kdqvoay.js gzip N/A 8.74 kB -
2s1ku9sx60j5g.js gzip N/A 155 B -
2smk18o7qzte6.js gzip N/A 154 B -
2zh8-mmhujy8o.js gzip N/A 2.29 kB -
30h_m0irj-q6p.js gzip N/A 221 B -
37ejbfx1u9lpo.js gzip N/A 8.75 kB -
38c63ct4i1cy7.js gzip N/A 449 B -
38pfb-vjc58zl.js gzip N/A 160 B -
3jimpal3lvz5e.js gzip N/A 9.44 kB -
3rxda-enqm36a.js gzip N/A 45 kB -
3su6a4l8jbfth.js gzip N/A 3.53 kB -
3vp18tbs9ie7b.js gzip N/A 156 B -
3wb4pe4z4-aim.js gzip N/A 8.77 kB -
43cuc9gzge2dj.js gzip N/A 151 B -
turbopack-0r..o21k.js gzip N/A 3.77 kB -
turbopack-0v..6n4f.js gzip N/A 3.78 kB -
turbopack-1-..44vs.js gzip N/A 3.76 kB -
turbopack-12..bfke.js gzip N/A 3.77 kB -
turbopack-1a..ll78.js gzip N/A 3.77 kB -
turbopack-1j..lqtq.js gzip N/A 3.77 kB -
turbopack-1v..tzol.js gzip N/A 3.79 kB -
turbopack-1x..lsi3.js gzip N/A 3.78 kB -
turbopack-2i..bzur.js gzip N/A 3.77 kB -
turbopack-3_..wlef.js gzip N/A 3.77 kB -
turbopack-3-..hdvm.js gzip N/A 3.77 kB -
turbopack-3l..eco6.js gzip N/A 3.77 kB -
turbopack-3m..txtb.js gzip N/A 3.77 kB -
turbopack-3w..c3ex.js gzip N/A 3.78 kB -
Total 447 kB 447 kB ⚠️ +46 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 757 B 748 B 🟢 9 B (-1%)
Total 757 B 748 B ✅ -9 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 431 B 436 B 🔴 +5 B (+1%)
Total 431 B 436 B ⚠️ +5 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2486.HASH.js gzip 169 B N/A -
3146-HASH.js gzip 64 kB N/A -
39fcf99b-HASH.js gzip 62.9 kB N/A -
8443-HASH.js gzip 4.68 kB N/A -
9431-HASH.js gzip 5.62 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 257 B 254 B 🟢 3 B (-1%)
main-HASH.js gzip 39.7 kB 40.1 kB 🔴 +452 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB
6105-HASH.js gzip N/A 5.63 kB -
764.HASH.js gzip N/A 169 B -
8898-HASH.js gzip N/A 63.4 kB -
9597-HASH.js gzip N/A 4.65 kB -
e1ccab69-HASH.js gzip N/A 62.9 kB -
Total 239 kB 238 kB ✅ -202 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 182 B
css-HASH.js gzip 335 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 255 B 254 B
head-HASH.js gzip 351 B 349 B
hooks-HASH.js gzip 384 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 313 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.96 kB 7.95 kB ✅ -7 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 128 kB 128 kB
page.js gzip 283 kB 285 kB 🔴 +2.36 kB (+1%)
Total 411 kB 413 kB ⚠️ +2.03 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 619 B 617 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 45.6 kB 45.3 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 47.2 kB 46.9 kB ✅ -262 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 720 B
Total 719 B 720 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.81 MB 4.8 MB 🟢 9.25 kB (0%)
index.pack gzip 118 kB 119 kB
index.pack.old gzip 120 kB 119 kB 🟢 1.53 kB (-1%)
Total 5.05 MB 5.04 MB ✅ -10.3 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 364 kB 364 kB
app-page-exp..prod.js gzip 201 kB 201 kB
app-page-tur...dev.js gzip 364 kB 364 kB
app-page-tur..prod.js gzip 201 kB 201 kB
app-page-tur...dev.js gzip 360 kB 360 kB
app-page-tur..prod.js gzip 199 kB 199 kB
app-page.run...dev.js gzip 361 kB 361 kB
app-page.run..prod.js gzip 199 kB 199 kB
app-route-ex...dev.js gzip 81.5 kB 81.5 kB
app-route-ex..prod.js gzip 55.4 kB 55.4 kB
app-route-tu...dev.js gzip 81.6 kB 81.6 kB
app-route-tu..prod.js gzip 55.4 kB 55.4 kB
app-route-tu...dev.js gzip 81.2 kB 81.2 kB
app-route-tu..prod.js gzip 55.2 kB 55.2 kB
app-route.ru...dev.js gzip 81.1 kB 81.1 kB
app-route.ru..prod.js gzip 55.2 kB 55.2 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 45.2 kB 45.2 kB
pages-api-tu..prod.js gzip 34 kB 34 kB
pages-api.ru...dev.js gzip 45.2 kB 45.2 kB
pages-api.ru..prod.js gzip 33.9 kB 33.9 kB
pages-turbo....dev.js gzip 54.7 kB 54.7 kB
pages-turbo...prod.js gzip 39.6 kB 39.6 kB
pages.runtim...dev.js gzip 54.7 kB 54.7 kB
pages.runtim..prod.js gzip 39.6 kB 39.6 kB
server.runti..prod.js gzip 67.5 kB 67.5 kB
use-cache-pr...dev.js gzip 71.4 kB 71.4 kB
use-cache-pr...dev.js gzip 71.4 kB 71.4 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
Total 3.49 MB 3.49 MB ✅ -3 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api.runtime.dev.js
  • pages.runtime.dev.js
View diffs
pages-api.runtime.dev.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/51ba8b264c2d4c768d1efb92d8fbb994f365afe9/next

Commit: 51ba8b2

@devjiwonchoi
devjiwonchoi force-pushed the jiwon/ts-plugin-preserve-quick-info branch from ce7335e to 51ba8b2 Compare July 16, 2026 14:58
@devjiwonchoi
devjiwonchoi marked this pull request as ready for review July 23, 2026 21:22
@timneutkens
timneutkens merged commit 2682437 into canary Jul 24, 2026
128 checks passed
@timneutkens
timneutkens deleted the jiwon/ts-plugin-preserve-quick-info branch July 24, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants