fix(onboarding): surface MCP setup prompt when config is absent#53
Merged
Conversation
… smoke) probe_mcp_status returned a single neutral "no mcp.json" row even when no config existed, so the onboarding readiness check `!mcp.rows.isEmpty` was always true and the new mcpSetupPrompt (PR #52) was dead code. Add a `configured` flag on McpStatusReport: false when there is no config yet (missing mcp.json OR present-but-no-servers), true otherwise (including a present-but-broken config — the file exists, show the concrete error, not the onboarding prompt). Carry it through CsMcpStatusReport to Swift and gate the readiness step on `mcp.configured` instead of row count. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (caught in runtime smoke of #52)
The guided MCP setup prompt shipped in #52 never appeared:
probe_mcp_statushonestly returns a single status row ("no mcp.json (optional — MCP off)") even when nothing is configured, so the Swift condition!mcp.rows.isEmptywas always true and themcpSetupPromptbranch was dead code.Fix
McpStatusReportgains aconfigured: boolflag —falsewhenmcp.jsonis absent or the config has zero servers,trueotherwise (including present-but-broken configs, which should surface their error status rather than an onboarding prompt).CsMcpStatusReport(UniFFI) and the onboarding condition switches from row-count tomcp.configured. No visual changes to the prompt itself.listServers(), not status rows).Tests / gates
Probe tests extended for both flag states;
cargo fmt --check,clippy -D warnings, tests acrosscodescribe/-core/-ffi, debug + signed release build — all green. One unrelated preexisting flake noted (hotkeys settings-isolation test, passes solo and on re-run; untouched by this change).🤖 Generated with Claude Code