fix(onboarding): open Settings via SwiftUI openSettings action#54
Merged
Conversation
…smoke) The onboarding readiness step's 'Set up MCP servers' button routed through OnboardingViewModel.openMcpSettings(), which called NSApp.sendAction(showSettingsWindow:). In this accessory / LSUIElement app that private selector has no responder, so the click did nothing. Switch to the canonical path used by TrayMenuView / AgentChatView: the view holds @Environment(\.openSettings) and calls it after the VM arms the one-shot deep-link (SettingsDeepLink.pendingSection = .engine). The VM method is renamed openMcpSettings() -> prepareMcpSettingsDeepLink() and no longer touches AppKit (import dropped). The Settings scene activates the app and orders its window front, above the wizard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (caught in runtime smoke of #53)
The MCP setup prompt now renders (#53), but clicking Set up MCP servers did nothing: the view model routed through
NSApp.sendAction(Selector(("showSettingsWindow:"))), which has no responder in this accessory (LSUIElement) SwiftUI-lifecycle app.Fix
@Environment(\.openSettings), called directly from the view.prepareMcpSettingsDeepLink(), which only armsSettingsDeepLink.pendingSection = .enginebefore the view invokesopenSettings()— deep-link to the Engine section preserved, consumed inSettingsView.onAppear.Gates
cargo fmt --check/clippy -D warningsclean · debug and release builds BUILD SUCCEEDED.🤖 Generated with Claude Code