add warning to vg augment -i for nameless paths - #4984
Merged
Conversation
adamnovak
approved these changes
Jul 31, 2026
adamnovak
left a comment
Member
There was a problem hiding this comment.
I don't think there's anything about generic paths that says the empty string can't be a path name. But it is indeed kind of an Air Bud situation.
Contributor
|
If we want to maintain compatibility with GFA, generic path names must be non-empty, as they have to match regex |
Member
|
Hmm. Unless we want to fail at GFA export, maybe we should indeed make this warning an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg augment -iwarns when it is told to embed a path without a nameDescription
Resolves #500 (the
-ioption moved fromvg modtovg augmentin the interim). I could easily be convinced that this should be an error instead.