Skip to content

add warning to vg augment -i for nameless paths - #4984

Merged
adamnovak merged 1 commit into
masterfrom
nameless-embed
Jul 31, 2026
Merged

add warning to vg augment -i for nameless paths#4984
adamnovak merged 1 commit into
masterfrom
nameless-embed

Conversation

@faithokamoto

Copy link
Copy Markdown
Contributor

Changelog Entry

To be copied to the draft changelog by merger:

  • vg augment -i warns when it is told to embed a path without a name

Description

Resolves #500 (the -i option moved from vg mod to vg augment in the interim). I could easily be convinced that this should be an error instead.

@adamnovak adamnovak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's anything about generic paths that says the empty string can't be a path name. But it is indeed kind of an Air Bud situation.

@adamnovak
adamnovak merged commit b6beeea into master Jul 31, 2026
2 checks passed
@jltsiren

Copy link
Copy Markdown
Contributor

If we want to maintain compatibility with GFA, generic path names must be non-empty, as they have to match regex [!-)+-<>-~][!-~]*.

@adamnovak

Copy link
Copy Markdown
Member

Hmm. Unless we want to fail at GFA export, maybe we should indeed make this warning an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cyclic alignments with MEM threading / should path inclusion in vg mod warn when an unnamed path is used?

3 participants