Skip to content

feat(core): bump luma.gl to latest - #10521

Merged
Pessimistress merged 3 commits into
masterfrom
x/luma-bump
Aug 3, 2026
Merged

feat(core): bump luma.gl to latest#10521
Pessimistress merged 3 commits into
masterfrom
x/luma-bump

Conversation

@Pessimistress

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Aug 3, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 83.766% (+0.7%) from 83.077% — x/luma-bump into master

});

test('DeckGL#real WebGPU device draws through the React custom render loop', async ({skip}) => {
test.skip('DeckGL#real WebGPU device draws through the React custom render loop', async ({

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibgreen This test is causing a cascade of tests to fail. It creates a racing condition in Deck's mutation of the same ShaderAssembler instance based on device type:

export function getShaderAssembler(language: 'glsl' | 'wgsl'): ShaderAssembler {
const shaderAssembler = ShaderAssembler.getDefaultShaderAssembler();
for (const shaderModule of DEFAULT_MODULES) {
shaderAssembler.addDefaultModule(shaderModule);
}
// if we're recreating the device we may have changed language
// and must not inject hooks for the wrong language
// shaderAssembler.resetShaderHooks();
(shaderAssembler as any)._hookFunctions.length = 0;
// Add shader hooks based on language
// TODO(ibgreen) - should the luma shader assembler support both sets of hooks?
const shaderHooks = language === 'glsl' ? SHADER_HOOKS_GLSL : SHADER_HOOKS_WGSL;
for (const shaderHook of shaderHooks) {
shaderAssembler.addShaderHook(shaderHook);
}
return shaderAssembler;
}

@Pessimistress
Pessimistress merged commit 047e828 into master Aug 3, 2026
3 checks passed
@Pessimistress
Pessimistress deleted the x/luma-bump branch August 3, 2026 07:14
@chrisgervang chrisgervang added this to the v9.4 milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants