fix(extensions): omit dash uniforms for offset-only path styles - #10607
Merged
Conversation
Greptile SummaryThe PR conditionally declares PathStyle dash uniform metadata only when dashing is enabled, avoiding an unused uniform block for offset-only paths.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| modules/extensions/src/path-style/path-style-extension.ts | Gates PathStyle uniform metadata on the dash option while retaining shader injection for offset-only configurations. |
| test/modules/extensions/path.spec.ts | Verifies dash-enabled modules retain uniform metadata and offset-only modules omit it; the previously flagged callback names are now descriptive. |
Reviews (5): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile
Collaborator
Author
|
Stack note: this branch contains an append-only merge of prerequisite #10609. GitHub native stacks would not allow retargeting #10607 onto #10609, so both PRs remain based on master; once #10609 lands, #10607's effective diff reduces to the offset-only uniform change and its regression test. No history was rewritten or force-pushed. |
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: Prerequisite for the six PathStyle feature PRs; base
master. #10609 is now inmaster, and this branch has synchronized it through an append-only parent merge. The historical prerequisite commit and merge remain visible in the immutable commit list, while the effective diff contains only the PathStyle uniform change and its regression test.Goal
Avoid allocating a PathStyle dash uniform block when the extension enables path offsets but not dashing.
Changes
pathStyle.uniformTypesonly when dashing is enabled.master.Measured resource benefit
Measured in headless Chromium/WebGL2 with one minimal offset-only
PathLayer, comparing the direct fix02744cdb65with its parent on the same luma.gl 9.4.0-beta.3 build:pathStyleUniformsbindingThis saves one GPU buffer object, one binding, and 1 KiB of managed UBO allocation per instantiated offset-only PathLayer model. It also removes the missing-layout warning for
pathStyleUniforms. The assembled vertex and fragment shaders are byte-for-byte identical, so this PR does not claim a shader-throughput or steady-state frame-time improvement. Dash-enabled layers retain the block.Validation
yarn vitest run --project headless test/modules/extensions/path.spec.ts.