fix(core): stop password managers from offering to save the OTP auth code#404
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The client-authorization OTP form (
ViewBuiltinClientAuthNotice.vue\u2192OtpInput.vue) already hintedautocomplete="one-time-code"on each digit box for autofill, but nothing told browsers/password managers to skip offering to save the entered code as a credential.autocomplete="off"on the wrapping<form>\u2014 the primary signal native browser password managers (Chrome/Firefox/Safari) use to skip a save-credential prompt on submit.data-1p-ignore,data-lpignore="true",data-bwignore="true", anddata-form-type="other"on each digit<input>\u2014 the attributes 1Password, LastPass, Bitwarden, and Dashlane respectively check to suppress their own save offers.Linked Issues
Additional context
Verified with
pnpm eslinton the changed files; no functional/behavioral change to the OTP flow itself.Created with the help of an AI agent.