feat(core): fold group side nav overflow into a height-based show-more#467
Merged
Conversation
When a group has more members than the panel is tall enough to show, the group side nav previously scrolled. Instead, measure the rail's frame height and fold the members that don't fit into a bottom "show more" button that opens the members in a flyout, so the rail never scrolls. The show-more button carries a hidden-member count and lights up when the active tool is one of the hidden members, so a hidden selection stays discoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a group has more members than the panel is tall enough to show, the group side nav (
DockGroupSidebar) previously just scrolled. This folds the members that don't fit into a bottom "show more" button that opens them in a flyout, driven by the rail's measured frame height — so the rail never scrolls.useElementBounding(mirroringDockPanel). A new purederiveSidebarCapacityhelper turns the available height into an integer capacity, then feeds the existingdocksSplitGroupsWithCapacitysplit. It reserves the show-more button's slot only once overflow is unavoidable (two-pass), and budgets for sub-category dividers so a multi-sub-category group never clips.DockGroupPopover(passed only the overflowed members), opened through a dedicateddocksSidebarOverflowPanelfloating slot (placementright) so it stays independent of the dock bar's group/overflow popovers. The trigger matches the dock bar'sDockOverflowButton— the same dots icon and a9+-capped count badge.of-y-autotoof-y-hidden; all three hosts (DockPanel,DockStandalone,DockEdge) inherit the behavior.Linked Issues
Additional context
dock-sidebar-capacity.test.ts).OverflowStorybook story on a constrained-height shell demonstrates the folded rail with a highlighted show-more button.pnpm lint,pnpm test,pnpm typecheck, andpnpm buildall pass. The.generated/css.tschange is the UnoCSS artifact regenerated from the new template classes.This PR was created with the help of an agent.