fix(core): command palette dark-on-dark text + glass-panel mismatch#478
Merged
antfu merged 1 commit intoJul 27, 2026
Merged
Conversation
… contrast The command palette's search input and dialog surface used `text-base` (UnoCSS's font-size utility) where `color-base` (the dark-aware text-color shortcut) was clearly intended — `text-base` sets no color at all, so input text fell back to the browser default (dark) on top of the dialog's own dark-mode background, rendering it unreadable. Same typo also affected the pin-toggle icons in the Docks settings view. Also switch the palette dialog's opaque `bg-base` to `bg-glass:75`, matching the translucent/blurred surface already used by the docked panels (DockPanel.vue, DockEdge.vue) so the palette's look is consistent with the rest of the floating dock chrome.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The command palette overlay (Cmd+K) had two small visual bugs, both traced to a shortcut-name typo:
text-base— that's UnoCSS/Tailwind's built-in font-size utility (font-size: 1rem), not a color shortcut. It sets nocolorat all. The dark-aware text-color shortcut in this repo iscolor-base(packages/ui/src/unocss/shared-shortcuts.ts). Since the dialog background correctly switches to near-black in dark mode but the input text fell back to the browser default, the result was unreadable text in dark mode.bg-basebackground, while the actual docked panels (DockPanel.vue,DockEdge.vue) both use the translucent/blurredbg-glass:75shortcut. The palette was the one surface that didn't match the rest of the floating dock chrome.Changes
CommandPalette.vue:text-base→color-baseon the search input;bg-base→bg-glass:75 color-baseon the dialog surface (matchesDockPanel.vue/DockEdge.vueexactly).SettingsDocks.vue: sametext-base→color-basetypo fix on the two pin-toggle icons (identical bug, bundled since it's a one-line, zero-risk fix).|
Test plan
playgrounds/coredev server, dark mode: command palette input text is now readable, dialog background matches the docked panel's glass/blur look (confirmed via computed styles:background-color: rgba(17,17,17,0.75),backdrop-filter: blur(7px), identical toDockPanel/DockEdge).pnpm run typecheck(vue-tsc -b) clean.