Skip to content

fix(ui): prevent dark mode from mutating host document#480

Merged
antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/ui-prevent-dark-mode-host-mutation
Jul 27, 2026
Merged

fix(ui): prevent dark mode from mutating host document#480
antfu merged 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/ui-prevent-dark-mode-host-mutation

Conversation

@SaKaNa-Y

Copy link
Copy Markdown
Collaborator

Description

Close #479

Linked Issues

Additional context

@pkg-pr-new

pkg-pr-new Bot commented Jul 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@480

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@480

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@480

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@480

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@480

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@480

commit: adf67f1

@SaKaNa-Y

Copy link
Copy Markdown
Collaborator Author

For #479, only modifying ViteDevTools.vue is enough to fix the reported issue. The changes in the other files are a further refactor of the dark mode composable, intended to prevent other components from encountering the same issue.

@antfu
antfu merged commit 2ee70f6 into vitejs:main Jul 27, 2026
7 checks passed
@SaKaNa-Y
SaKaNa-Y deleted the fix/ui-prevent-dark-mode-host-mutation branch July 27, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overrides application theme

2 participants