refactor(ziextract): declare →zinit-extract once from a body variable

[Copilot]

ziextract's extension case statement repeated the →zinit-extract() { … } declaration in all 15 branches. Each branch now sets only the function body, and the function is declared in a single place.

Case statement

• Every branch assigns a single-quoted body string to a new local body instead of declaring a function. No expansion happens at assignment time; $file, ZINIT[tmp], and grep patterns resolve at call time as before.

Single declaration point

• →zinit-extract is created once after esac.
• [[ -n $body ]] replaces the $(typeset -f + →zinit-extract) subshell check that gated the extraction/warning=1 paths.

case "${${ext:+.$ext}:-$file}" in
    ((#i)*.zip)
        body='→zinit-check unzip "$file" || return 1; command unzip -qq -o "$file"'
        ;;
    # …
esac

if [[ -n $body ]] {
    builtin eval "→zinit-extract() { $body }"
    .zinit-extract-wrapper "$file" →zinit-extract || { … }

Notes for reviewers

• builtin eval is used rather than functions[→zinit-extract]=$body: zsh 5.9 mangles the multi-byte → in identifiers when parsing a body assigned through the functions array, breaking the →zinit-check calls. The evaluated string is a static literal.
• The .gz/.bz2/.xz branches keep their pre-existing file-rename logic outside the body assignment.
• Net −10 LOC.

• Fixes [maint]: reduce duplicate →zinit-extract declaration in ziextract case statement #1

[Copilot]

Pull request overview

Refactors ziextract to avoid repeating the →zinit-extract() function declaration across each archive-type case branch by storing per-branch extraction logic in a body variable and declaring the function once after the case.

Changes:

• Introduces a local body variable and updates each case branch to assign the extractor function body instead of redefining →zinit-extract().
• Declares →zinit-extract() once after esac (gated by [[ -n $body ]]) and runs extraction via .zinit-extract-wrapper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Added a newline terminator before the closing } when building the eval string in 378a439.

[Copilot]

Quoted $attached_vol in both cp (keeping the glob unquoted so it still expands) and hdiutil detach in 378a439.