feat: aggregate remote-bench-e2e results and compute success rate#31
Merged
Conversation
Adds collect-results + calc-success-rate stages after the matrix dispatch, mirroring e2e-tests.yml, so a multi-config batch produces one combined summary instead of only per-job artifacts. Deliberately still omits trigger-agentic-ingest: whether remote-bench results should auto-dispatch to InferenceX-app's production ingest is an open design question (issue #28), not a side effect of this change.
1 task
aistackdev
pushed a commit
that referenced
this pull request
Jul 24, 2026
…ndpoint) Adds remote-bench: benchmark an already-running, externally-managed inference endpoint instead of launching a server on the GPU runner. - benchmark_lib.sh: REMOTE_BASE_URL override in build_replay_cmd so aiperf points at an external endpoint instead of localhost. - benchmark-tmpl.yml: 6 optional remote-* workflow_call inputs/env vars, consumed only by *-remote-bench.sh recipes. - remote-bench-e2e.yml: single entrypoint, takes a JSON array of configs (one element for a smoke test, many for a full CCU-ladder sweep), matrix-fans to benchmark-tmpl.yml, then aggregates via collect-results + calc-success-rate. - Two model-agnostic *-remote-bench.sh recipes (dsv2lite fp8, glm5.2 fp4), the cluster:remote-bench runner label + non-GPU controller launcher (bench-client_01). - create-remote-bench skill: how to bring up a new recipe, including checking the endpoint's KV pool capacity to size a concurrency ladder, and the REMOTE_MAX_CONTEXT_LENGTH incident (a per-request cap is required, and even the model's nominal context window isn't automatically a safe value on small/dev GPUs). - sync-upstream + fork-changelog skills: since fork commits now live directly on main instead of a separate customization branch, syncing upstream is a real merge — fork-changelog lists every fork-only edit and why, sync-upstream is the procedure that checks against it. Background: issue #26/#28, PR #27/#30/#31/#34 (squashed into this single commit).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30. Adds
collect-results+calc-success-ratestages toremote-bench-e2e.yml, mirroringe2e-tests.yml's aggregation flow — a multi-config batch now produces one combinedresults_bmksummary +run-statsartifact instead of only scattered per-job artifacts.Deliberately still not adding
trigger-agentic-ingest: whether remote-bench results should auto-dispatch to InferenceX-app's production ingest is the open design question tracked in issue #28, not something to decide as a side effect of this change.Test plan
remote-bench-e2e.ymlwith a 2+ config batch and confirmresults_bmkandrun-statsartifacts both appear with real aggregated data