Skip to content

docs: sync-upstream/fork-changelog skills; consolidate remote-bench to one workflow#34

Closed
aistackdev wants to merge 6 commits into
mainfrom
chore/combine-32-33
Closed

docs: sync-upstream/fork-changelog skills; consolidate remote-bench to one workflow#34
aistackdev wants to merge 6 commits into
mainfrom
chore/combine-32-33

Conversation

@aistackdev

Copy link
Copy Markdown

Summary

Squashed combination of #32 and #33 into a single merge commit (per request — no need for two separate commits landing back to back for closely related doc/consolidation work):

  • Replaces the stale sync-remote-bench-with-main skill with sync-upstream (procedure) + fork-changelog (reference data of fork-only edits, with why).
  • Extends create-remote-bench to cover full CCU-ladder sweeps (check KV pool capacity before picking concurrency values).
  • Removes remote-bench.yml — only ever used for smoke-testing; remote-bench-e2e.yml already covers that via a one-element configs array.

Closes #32, closes #33 (superseded by this combined PR).

Test plan

  • Docs + workflow removal only — dispatch remote-bench-e2e.yml with a one-element configs array to confirm the smoke-test path still works with remote-bench.yml gone

Ngô Quang Hòa and others added 6 commits July 24, 2026 14:07
…ndpoint)

Adds remote-bench: a dedicated workflow_dispatch entrypoint and recipe
convention (*-remote-bench.sh) for benchmarking an already-running,
externally-managed inference endpoint instead of launching a server on
the GPU runner. Includes the REMOTE_BASE_URL override across
benchmark_lib.sh's serving/eval/replay call sites, the cluster:remote-bench
runner registration, and the create-remote-bench / sync-remote-bench-with-main
skills for bringing up new model configs and landing future changes onto
main without dragging in unrelated vng-benchmark commits.

Background: issue #26, PR #27.
Matrix-fans a JSON array of remote-bench configs to benchmark-tmpl.yml
in one dispatch, mirroring e2e-tests.yml's fan-out pattern. Takes the
config array directly instead of going through generate_sweep_configs.py,
so it stays independent of the closed master-config schema.
feat: add remote-bench-e2e.yml for batch remote-bench dispatch
Adds collect-results + calc-success-rate stages after the matrix
dispatch, mirroring e2e-tests.yml, so a multi-config batch produces one
combined summary instead of only per-job artifacts.

Deliberately still omits trigger-agentic-ingest: whether remote-bench
results should auto-dispatch to InferenceX-app's production ingest is
an open design question (issue #28), not a side effect of this change.
feat: aggregate remote-bench-e2e results and compute success rate
…o one workflow

Replaces the stale sync-remote-bench-with-main skill with two: sync-upstream
(the fetch/merge/resolve/verify/PR procedure) and fork-changelog (reference
list of fork-only edits on main, with why, to check during a sync).

Also extends create-remote-bench to cover full CCU-ladder sweeps (check the
KV pool's token capacity before picking concurrency values) and removes
remote-bench.yml — it was only used for smoke-testing, and
remote-bench-e2e.yml already covers a single-config smoke test via a
one-element configs array, so there's no reason to keep two entrypoints.

Squashed from PR #32 and #33.
aistackdev pushed a commit that referenced this pull request Jul 24, 2026
…ndpoint)

Adds remote-bench: benchmark an already-running, externally-managed
inference endpoint instead of launching a server on the GPU runner.

- benchmark_lib.sh: REMOTE_BASE_URL override in build_replay_cmd so
  aiperf points at an external endpoint instead of localhost.
- benchmark-tmpl.yml: 6 optional remote-* workflow_call inputs/env vars,
  consumed only by *-remote-bench.sh recipes.
- remote-bench-e2e.yml: single entrypoint, takes a JSON array of configs
  (one element for a smoke test, many for a full CCU-ladder sweep),
  matrix-fans to benchmark-tmpl.yml, then aggregates via
  collect-results + calc-success-rate.
- Two model-agnostic *-remote-bench.sh recipes (dsv2lite fp8, glm5.2
  fp4), the cluster:remote-bench runner label + non-GPU controller
  launcher (bench-client_01).
- create-remote-bench skill: how to bring up a new recipe, including
  checking the endpoint's KV pool capacity to size a concurrency ladder,
  and the REMOTE_MAX_CONTEXT_LENGTH incident (a per-request cap is
  required, and even the model's nominal context window isn't
  automatically a safe value on small/dev GPUs).
- sync-upstream + fork-changelog skills: since fork commits now live
  directly on main instead of a separate customization branch, syncing
  upstream is a real merge — fork-changelog lists every fork-only edit
  and why, sync-upstream is the procedure that checks against it.

Background: issue #26/#28, PR #27/#30/#31/#34 (squashed into this single
commit).
@aistackdev

Copy link
Copy Markdown
Author

Squashed directly onto main as a single commit (f5a3643d), covering #27/#30/#31/#32/#33/#34 — per request to consolidate everything into one commit.

@aistackdev aistackdev closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant