test(snapshots): migrate shim snap test cases#2109
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
5 times, most recently
from
19ba77e to
e59bd3e
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
6a35173 to
9dd2dc6
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
e59bd3e to
b37ddf9
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
9dd2dc6 to
576fd3b
Compare
fengmk2
changed the base branch from
migrate-migrate-snap-tests
to
graphite-base/2109
fengmk2
force-pushed
the
graphite-base/2109
branch
from
576fd3b to
f4cc891
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
b37ddf9 to
a3970fb
Compare
fengmk2
changed the base branch from
graphite-base/2109
to
migrate-migrate-snap-tests
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
a3970fb to
ae4c259
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
f4cc891 to
b9499f0
Compare
fengmk2
changed the base branch from
migrate-migrate-snap-tests
to
graphite-base/2109
fengmk2
force-pushed
the
graphite-base/2109
branch
from
b9499f0 to
cfbc122
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
ae4c259 to
6b86ed2
Compare
fengmk2
changed the base branch from
graphite-base/2109
to
fix-snap-registry-teardown
fengmk2
changed the title
This was referenced Jul 9, 2026
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
192de83 to
62fe14e
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
8397ec3 to
cfbc122
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
62fe14e to
0090d77
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
0090d77 to
8c6aa87
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
cfbc122 to
52ce2b9
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
8c6aa87 to
b1d4b85
Compare
fengmk2
force-pushed
the
graphite-base/2109
branch
from
52ce2b9 to
616c94e
Compare
fengmk2
changed the base branch from
graphite-base/2109
to
migrate-migrate-snap-tests
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
d8a042d to
caea915
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
616c94e to
e413787
Compare
wan9chi
approved these changes
Jul 10, 2026
Merge activity
|
Stacked on #2107. Migrates 7 of the 11 legacy `shim-*` global snap-test cases (node/npm/pnpm shim behavior) to the PTY snapshot suite: - `shim-inherits-parent-{dev-engines-runtime,engines-node,node-version}` - `shim-npm-uses-package-manager-version` - `shim-npm-ignores-mismatched-package-manager` - `shim-pnpm-uses-project-node-version` - `shim-recursive-npm-run` The `test "$(npm --version)" = X` version assertions become direct `npm`/`npx --version` steps whose pinned output is the snapshot. `npx` is added to the runner program allow-list (resolved from the case PATH, so the vp-managed shim wins). Deferred to a later batch, since they depend on shell features the PTY runner intentionally does not provide (`$VP_HOME` path references, `$(pwd)`/PATH overrides, fake runtimes, arbitrary installed binaries): `shim-corepack-bundled`, `shim-corepack-enable-install-directory`, `shim-npm-downloads-uncached-package-manager-version`, `shim-recursive-package-binary`.
graphite-app
Bot
force-pushed
the
migrate-migrate-snap-tests
branch
from
e413787 to
3b4829e
Compare
graphite-app
Bot
force-pushed
the
migrate-shim-snap-tests
branch
from
caea915 to
9a4fadd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2107.
Migrates 7 of the 11 legacy
shim-*global snap-test cases (node/npm/pnpm shim behavior) to the PTY snapshot suite:shim-inherits-parent-{dev-engines-runtime,engines-node,node-version}shim-npm-uses-package-manager-versionshim-npm-ignores-mismatched-package-managershim-pnpm-uses-project-node-versionshim-recursive-npm-runThe
test "$(npm --version)" = Xversion assertions become directnpm/npx --versionsteps whose pinned output is the snapshot.npxis added to the runner program allow-list (resolved from the case PATH, so the vp-managed shim wins).Deferred to a later batch, since they depend on shell features the PTY runner intentionally does not provide (
$VP_HOMEpath references,$(pwd)/PATH overrides, fake runtimes, arbitrary installed binaries):shim-corepack-bundled,shim-corepack-enable-install-directory,shim-npm-downloads-uncached-package-manager-version,shim-recursive-package-binary.