chore: bump vite-task to cb580c2#2126
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsbeRwtxNNtT2VA6YSRKa9
✅ Deploy Preview for viteplus-preview canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea56e9c3a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.28 MiB | 10.28 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.41 MiB | 4.41 MiB | +244 B (+0.01%) |
| NAPI (Linux x64) | Binary | 33.41 MiB | 33.41 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.78 MiB | 12.78 MiB | +564 B (+0.00%) |
vp (macOS ARM64) |
Binary | 7.61 MiB | 7.61 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.83 MiB | 3.82 MiB | -1.59 KiB (-0.04%) |
| NAPI (macOS ARM64) | Binary | 40.77 MiB | 40.77 MiB | -16 B (-0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 17.04 MiB | 17.04 MiB | -5.15 KiB (-0.03%) |
vp (Windows x64) |
Binary | 8.33 MiB | 8.33 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.63 MiB | 3.63 MiB | +515 B (+0.01%) |
| NAPI (Windows x64) | Binary | 27.86 MiB | 27.87 MiB | +6.50 KiB (+0.02%) |
| NAPI (Windows x64) | gzip -9 | 10.78 MiB | 10.78 MiB | +1.33 KiB (+0.01%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | -1 B (-0.00%) |
| Installer (Windows x64) | Binary | 4.46 MiB | 4.46 MiB | +1.00 KiB (+0.02%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | -192 B (-0.01%) |
fengmk2
approved these changes
Jul 10, 2026
…rotocol The cb580c2 vite-task bump changes pty_terminal_test::Reader::expect_milestone to decode milestones from window titles (OSC 2) instead of OSC 8 hyperlinks. The JS milestone encoder still emitted the old OSC 8 protocol, so any interactive snapshot waiting on a JS prompt milestone (select/confirm/text) would never match and time out. Update packages/prompts/src/milestone.ts to emit the new title protocol (OSC 2 ; pty-terminal-test:<32-hex-id>:<base64url(name)> ST, matching pty_terminal_test_client::encode_milestone_title byte for byte, with a fresh random id per emission), refresh the spec and the RFC/runner docs that described the old OSC 8 encoding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsbeRwtxNNtT2VA6YSRKa9
The milestone spec's regexes embedded ESC (U+001B), tripping oxlint's no-control-regex in vp check, and the inline decode helper tripped unicorn/consistent-function-scoping. Parse the marker with string ops via a module-scope helper instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsbeRwtxNNtT2VA6YSRKa9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
vite-taskgit dependency from417b6aatocb580c2.Changes in this bump
NtCreateUserProcess(vite-task#518)Both are bug fixes with no new CLI options, config fields, or changed defaults, so no docs updates are needed.
Validation
cargo check --workspace— cleanvite_command,vite_error,vite_install,vite_js_runtime,vite_migration,vite_shared,vite_static_config,vite-plus-cli,vite_global_cli) — pass withRUST_MIN_STACK=8388608Changelog diff:
https://github.com/voidzero-dev/vite-task/compare/417b6aae5fca92b128c586c8ff3421e43911b553...cb580c214bb2314fc1f633a3812782c9b3a1d956#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed🤖 Generated with Claude Code
https://claude.ai/code/session_01TsbeRwtxNNtT2VA6YSRKa9
Generated by Claude Code