fix(install): dispatch managed bunx through bun x#2151
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
The CI falling should be fixed in #2150. |
liangmiQwQ
force-pushed
the
liang/codex/fix-bunx-shim
branch
from
919ed21 to
686a8f5
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 686a8f5f84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| /// Refresh an older managed Bun installation without touching its native binary | ||
| /// or the separate `bun` wrappers. | ||
| async fn refresh_bunx_shim_if_needed(bin_prefix: &AbsolutePath) -> Result<(), Error> { |
There was a problem hiding this comment.
Should we add this refresh logic?
- If we don't add it, the fix won't work for already-installed Bun. (As Codex's review)
- If we add it, it will be a patch forever, maintaining this may make code not so clean.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Close #2123
Managed
bunxshims currently executebun.nativewithout preserving thebunxargv0. Bun then treatsbunx <package>asbun <package>, which can recursively invoke a matching package script.This PR generates the managed
bunxshims asbun.native x <args>for sh, Command Prompt, and PowerShell. The managedbunshim remains unchanged.🤖 Generated with Codex