fix(cli): handle stdout backpressure#2169
Open
hyoban wants to merge 5 commits into
Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Author
|
CI update: The Linux/macOS failures are unrelated snapshot drift: a run-day install date (already addressed by #2150) and newer package versions resolved from the registry. This PR does not touch those paths, so I have not included unrelated snapshot updates here. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cpojer
requested review from
jong-kyung and
wan9chi
and removed request for
cpojer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll(POLLOUT)and propagate non-retryable I/O errorsvp checkoutput helpers return write failures instead of discarding them or panickingWouldBlock, interrupted writes, terminal errors, and a real non-blocking Unix streamRoot cause
vp checkcaptures Oxlint diagnostics and replays them to stdout. When a consumer could not drain a non-blocking stdout pipe quickly enough,write_allreturnedWouldBlock. The diagnostic replay path discarded that error, so the diagnostics were truncated and a later standard-library print could panic while stdout was still unavailable.The new write loop preserves the unwritten suffix, waits until the stream is writable, and retries. Permanent failures are returned through the existing command result path.
Fixes #2165.
Validation
cargo test -p vite_shared waits_until_a_nonblocking_writer_is_ready_before_retryingjust checkjust lintjust testpnpm -F vite-plus buildjust snapshot-test check_(36 passed)