Skip to content

fix(cli): delegate command help to local cli - #2184

Merged
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-local-command-help
Aug 3, 2026
Merged

fix(cli): delegate command help to local cli#2184
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-local-command-help

Conversation

@liangmiQwQ

Copy link
Copy Markdown
Collaborator

Close #1995

The global CLI currently renders help for commands implemented by the local CLI, so its documentation can drift from the installed local toolchain.

This PR moves prepared help for delegated commands into the local CLI and routes global, local, and task-script help through the same themed renderer. It also refreshes the documented options to match the current tools while omitting config-file flags that Vite+ does not expose in this workflow.

🤖 Generated with Codex

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit ddf6a1d
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a7095c4198be40007472f96

@liangmiQwQ liangmiQwQ closed this Jul 16, 2026
@liangmiQwQ
liangmiQwQ force-pushed the liang/codex/fix-local-command-help branch from b7435e4 to 327d23a Compare July 16, 2026 05:23
@liangmiQwQ liangmiQwQ reopened this Jul 16, 2026
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d31e3c6d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/help.ts
Comment thread crates/vite_global_cli/src/cli.rs Outdated
Comment thread packages/cli/src/help.ts
Comment thread packages/cli/src/help.ts
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review July 20, 2026 03:05
@liangmiQwQ
liangmiQwQ requested a review from wan9chi July 22, 2026 10:27
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

I will handle merge conflict after #2211 merges. cc @wan9chi

For maintainability issues, I plan to handle this in a separate PR, which introduces a CI helper to find differs and let Claude to update.

@wan9chi

wan9chi commented Jul 22, 2026

Copy link
Copy Markdown
Member

@liangmiQwQ Take your time. This change will need mk's review.

@wan9chi
wan9chi requested a review from fengmk2 July 22, 2026 10:36
fengmk2

This comment was marked as resolved.

@fengmk2

fengmk2 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Let me fix conflicts before merge.

@fengmk2
fengmk2 force-pushed the liang/codex/fix-local-command-help branch 2 times, most recently from adf9cd8 to a1da8a4 Compare August 3, 2026 11:31
@fengmk2
fengmk2 force-pushed the liang/codex/fix-local-command-help branch from a1da8a4 to ca6faec Compare August 3, 2026 11:45
@fengmk2

fengmk2 commented Aug 3, 2026

Copy link
Copy Markdown
Member

@codex review

@fengmk2 fengmk2 self-assigned this Aug 3, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 63dd37b4d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2

fengmk2 commented Aug 3, 2026

Copy link
Copy Markdown
Member

@liangmiQwQ Continuously synchronizing the CLI command parameters we depend on needs to be a follow-up task. This could be achieved by adding prompts to https://github.com/voidzero-dev/vite-plus/blob/main/.github/workflows/upgrade-deps.yml

@fengmk2
fengmk2 merged commit 5981c6e into voidzero-dev:main Aug 3, 2026
44 checks passed
@liangmiQwQ
liangmiQwQ deleted the liang/codex/fix-local-command-help branch August 3, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delegate command's --help to local cli

3 participants