docs: add RFC for add/remove package commands with workspace support by fengmk2 · Pull Request #220 · voidzero-dev/vite-plus

fengmk2 · 2025-10-11T06:09:18Z

Add comprehensive RFC for vite add and vite remove commands that provide
a unified interface for package management across pnpm/yarn/npm with full
workspace support following pnpm's API design.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

fengmk2 · 2025-10-11T06:09:34Z

docs: add RFC for add/remove package commands with workspace support #220 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Add comprehensive RFC for `vite add` and `vite remove` commands that provide a unified interface for package management across pnpm/yarn/npm with full workspace support following pnpm's API design. Key features: - Auto-detection of package manager (pnpm/yarn/npm) - Multiple package support in single command - Workspace filtering with pnpm-inspired syntax (--filter) - Workspace root operations (-w flag) - Workspace protocol support (--workspace for pnpm) - Common flag translation (-D, -E, -P, -O, -g) - Command aliases (rm, un, uninstall) - No caching overhead (direct execution) Filter patterns (pnpm-focused): - Exact match: --filter app - Wildcards: --filter "app*" - Scope: --filter "@myorg/*" - Exclusion: --filter "!test*" - Dependencies: --filter "app..." - Graceful degradation for yarn/npm Examples: vite add react --filter app vite add @myorg/utils --workspace --filter web vite add typescript -D -w vite remove lodash --filter "app*" Implementation follows existing install command pattern with new add.rs and remove.rs modules. Package manager adapter provides command translation with proper argument ordering for each PM. RFC includes: - Complete command mapping for all package managers - Workspace filter patterns and compatibility matrix - Implementation architecture with code samples - Test strategy with 12 test cases - Real-world monorepo workflow examples - Phased implementation plan (MVP → Workspace → Advanced) - 1,373 lines of comprehensive design documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

Adds an RFC proposing new vite add and vite remove commands that provide a unified package management interface across pnpm/yarn/npm with workspace-aware behavior modeled after pnpm’s API.

Introduces command syntax, flag mapping, and workspace filter semantics
Outlines implementation architecture with Rust code sketches (CLI, adapters)
Documents testing strategy, UX, and future enhancements

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-20T13:29:18Z

+                if !filters.is_empty() {
+                    // yarn workspace <name> add
+                    for filter in filters {
+                        args.push("workspace".to_string());
+                        args.push(filter.clone());
+                    }


For yarn, multiple workspace targets cannot be batched by repeating workspace <name> in a single command. yarn workspace <name> add ... must be run once per workspace, or the implementation should restrict yarn to a single --filter (e.g., use only filters.first() or error when filters.len() > 1). The current approach would yield an invalid command like yarn workspace app workspace web add react.

Suggested change

if !filters.is_empty() {

// yarn workspace <name> add

for filter in filters {

args.push("workspace".to_string());

args.push(filter.clone());

}

if let Some(filter) = filters.first() {

// yarn only supports a single workspace per command

args.push("workspace".to_string());

args.push(filter.clone());

Copilot · 2025-10-20T13:29:19Z

+            PackageManagerType::Yarn => {
+                if !filters.is_empty() {
+                    for filter in filters {
+                        args.push("workspace".to_string());
+                        args.push(filter.clone());
+                    }
+                }
+                args.push("remove".to_string());
+                args.extend_from_slice(packages);
+                args.extend_from_slice(extra_args);


Same issue as add: yarn cannot repeat workspace <name> to target multiple workspaces in one command. Either restrict yarn to a single filter (use only the first filter) or execute yarn workspace <name> remove ... once per targeted workspace.

Copilot · 2025-10-20T13:29:19Z

+    #[command(disable_help_flag = true)]
+    Add {
+        /// Packages to add
+        packages: Vec<String>,
+
+        /// Filter packages in monorepo (can be used multiple times)
+        #[arg(long, value_name = "PATTERN")]
+        filter: Vec<String>,
+
+        /// Add to workspace root (ignore-workspace-root-check)
+        #[arg(short = 'w', long)]
+        workspace_root: bool,
+
+        /// Only add if package exists in workspace
+        #[arg(long)]
+        workspace: bool,
+
+        /// Arguments to pass to package manager
+        #[arg(allow_hyphen_values = true, trailing_var_arg = true)]
+        args: Vec<String>,
+    },


With this clap definition, examples like vite add -D typescript will fail because -D (and similar flags) aren’t defined options and occur before the positional packages. trailing_var_arg only helps once positional parsing begins. To match the documented UX, define the common flags (e.g., -D/-E/-P/-O/-g) as explicit clap options and then forward them to the package manager (or require flags to follow -- or come after packages, and update examples accordingly).

Copilot · 2025-10-20T13:29:19Z

+    },
+
+    /// Remove packages from dependencies
+    #[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]


[nitpick] Prefer using aliases = [\"rm\", \"un\", \"uninstall\"] in clap rather than repeating alias = ... for readability and to avoid attribute parsing pitfalls.

Suggested change

#[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]

#[command(disable_help_flag = true, aliases = ["rm", "un", "uninstall"])]

Copilot · 2025-10-20T13:29:20Z

+    // ... existing commands
+
+    /// Add packages to dependencies
+    #[command(disable_help_flag = true)]


The CLI help sections advertise -h, --help for both commands (e.g., lines 939–940 and 975), but disable_help_flag = true removes the default help flags. Either drop disable_help_flag or add an explicit help flag to align the implementation sketch with the documented help output.

Copilot · 2025-10-20T13:29:20Z

+| `-g, --global`                       | `-g`                     | `global add`          | `--global` / `-g`           | Install globally                                    |
+| `--save-catalog`                     | `--save-catalog`         | `--save-catalog`      | N/A                         | Save the new dependency to the default catalog      |
+| `--save-catalog-name <catalog_name>` | SAME                     | N/A                   | N/A                         | Save the new dependency to the specified catalog    |
+| `--allow-build <names>`              | SAME                     | N/A                   | N/A                         | A list of package names allowed to run postinstall  |
+
+**Note**: For pnpm, `--filter` must come before the command (e.g., `pnpm --filter app add react`). For yarn/npm, it's integrated into the command structure.
+


Copilot · 2025-10-20T13:29:20Z

+    },
+
+    /// Remove packages from dependencies
+    #[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]


[nitpick] The help text lists Aliases: rm, un, uninstall (line 966) which matches the intent, but if disable_help_flag = true is retained to provide custom help, ensure these aliases appear in the actual generated help output (or remove disable_help_flag so clap includes them automatically).

Suggested change

#[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]

#[command(alias = "rm", alias = "un", alias = "uninstall")]

Copilot · 2025-10-20T13:29:20Z

+
+### 2. Interactive Mode
+
+> Referer to ni's interactive mode https://github.com/antfu-collective/ni


Corrected spelling of 'Referer' to 'Refer'.

Suggested change

> Referer to ni's interactive mode https://github.com/antfu-collective/ni

> Refer to ni's interactive mode https://github.com/antfu-collective/ni

Copilot · 2025-10-20T13:29:21Z

+  -w, --workspace-root Add to workspace root (ignore-workspace-root-check)
+  --workspace          Only add if package exists in workspace
+  -D, --save-dev       Add as dev dependency
+  -P, --save-peer      Add as peer dependency


[nitpick] This description can mislead: --save-peer typically writes to peerDependencies and also to devDependencies (pnpm, npm, and Yarn Classic). Consider clarifying with 'Add as peer dependency (also saved to devDependencies by most package managers)'.

Suggested change

-P, --save-peer Add as peer dependency

-P, --save-peer Add as peer dependency (also saved to devDependencies by most package managers)

Includes: - feat: tree-view task selector with grouped packages (#219) - fix: align package headers with top-level items in task selector (#220) - chore: Adjust `vp run` output styling (#213) - Improve shell quote handling with proper nested quote support (#217) Update snap tests for `[vp run]` → `vp run:` output styling change. https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U

Includes: - feat: tree-view task selector with grouped packages (#219) - fix: align package headers with top-level items in task selector (#220) - chore: Adjust `vp run` output styling (#213) - Improve shell quote handling with proper nested quote support (#217) Update snap tests for `[vp run]` → `vp run:` output styling change. Add cross-platform normalization for `cat:` error message spacing. https://claude.ai/code/session_0139LsSbe67hcD8NKKaK6Y8U

## Summary - Bumps vite-task dependency from 4bbcba17 to 6fdc4f10 Includes: - feat: tree-view task selector with grouped packages (#219) - fix: align package headers with top-level items in task selector (#220) - chore: Adjust vp run output styling (#213) - Improve shell quote handling with proper nested quote support (#217) Updates snap tests for output styling change. ## Test plan - [x] cargo check --all-targets --all-features passes locally - [ ] CI passes on all platforms

fengmk2 mentioned this pull request Oct 11, 2025

feat(pm): vite add command for package installation #221

Merged

fengmk2 force-pushed the add-package-rfc branch 2 times, most recently from 1860a27 to 22b3974 Compare October 16, 2025 08:26

fengmk2 mentioned this pull request Oct 16, 2025

refactor(pm): rename resolve_commmand to resolve_install_command #229

Merged

fengmk2 force-pushed the add-package-rfc branch from 22b3974 to 6eab11a Compare October 17, 2025 07:17

fengmk2 and others added 2 commits October 20, 2025 10:54

FIXUP

57ebac3

fengmk2 force-pushed the add-package-rfc branch from 6eab11a to 57ebac3 Compare October 20, 2025 03:27

fengmk2 mentioned this pull request Oct 20, 2025

feat(pm): add remove command for package dependencies #237

Merged

fengmk2 requested review from Brooooooklyn and branchseer October 20, 2025 13:24

fengmk2 marked this pull request as ready for review October 20, 2025 13:24

Copilot AI review requested due to automatic review settings October 20, 2025 13:24

Copilot AI reviewed Oct 20, 2025

View reviewed changes

fengmk2 closed this Oct 21, 2025

branchseer mentioned this pull request Mar 11, 2026

chore: bump vite-task to 6fdc4f10 #777

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add RFC for add/remove package commands with workspace support#220

docs: add RFC for add/remove package commands with workspace support#220
fengmk2 wants to merge 2 commits intomainfrom
add-package-rfc

fengmk2 commented Oct 11, 2025 •

edited

Loading

Uh oh!

fengmk2 commented Oct 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	#[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]
	#[command(disable_help_flag = true, aliases = ["rm", "un", "uninstall"])]

	#[command(disable_help_flag = true, alias = "rm", alias = "un", alias = "uninstall")]
	#[command(alias = "rm", alias = "un", alias = "uninstall")]


		### 2. Interactive Mode

		> Referer to ni's interactive mode https://github.com/antfu-collective/ni

	> Referer to ni's interactive mode https://github.com/antfu-collective/ni
	> Refer to ni's interactive mode https://github.com/antfu-collective/ni

	-P, --save-peer Add as peer dependency
	-P, --save-peer Add as peer dependency (also saved to devDependencies by most package managers)

Conversation

fengmk2 commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengmk2 commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Oct 11, 2025 •

edited

Loading

fengmk2 commented Oct 11, 2025 •

edited

Loading