fix(check): resolve typecheck options inherited through lint extends#2228
Open
jong-kyung wants to merge 3 commits into
Open
fix(check): resolve typecheck options inherited through lint extends#2228jong-kyung wants to merge 3 commits into
jong-kyung wants to merge 3 commits into
Conversation
Honor nested extends precedence when deciding whether the check command should run and label type checking.
Verify typecheck-only execution both with and without the format phase while preserving the existing direct-config snapshots.
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 400bd38558
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jong-kyung
force-pushed
the
fix/2225-lint-extends-typecheck
branch
from
July 23, 2026 08:44
400bd38 to
4a8d38a
Compare
✅ Deploy Preview for viteplus-preview canceled.
|
jong-kyung
marked this pull request as ready for review
July 23, 2026 08:47
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeAwareandtypeCheckoptions using Oxlint’s merge precedence sovp check --no-lintandvp check --no-fmt --no-lintrun and classify type checking correctly.Fixes #2225