refactor(global-cli): drop redundant clippy allow attributes - #2235
Merged
fengmk2 merged 3 commits intoAug 2, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
…ppy_allow_attributes
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.31 MiB | 10.31 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.43 MiB | 4.43 MiB | +1 B (+0.00%) |
| NAPI (Linux x64) | Binary | 33.08 MiB | 33.08 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.73 MiB | 12.73 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.65 MiB | 7.65 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.84 MiB | 3.84 MiB | -2 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 40.50 MiB | 40.50 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | +22 B (+0.00%) |
vp (Windows x64) |
Binary | 8.36 MiB | 8.36 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.64 MiB | 3.64 MiB | +1 B (+0.00%) |
| NAPI (Windows x64) | Binary | 27.52 MiB | 27.52 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +2 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.45 MiB | 4.45 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | -1 B (-0.00%) |
fengmk2
approved these changes
Aug 2, 2026
…ppy_allow_attributes
fengmk2
deleted the
07-24-refactor_global-cli_drop_redundant_clippy_allow_attributes
branch
August 2, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crates/vite_global_cli/src/shim/dispatch.rshad six function-level clippy#[allow(...)]attributes (onget_npm_global_prefix,check_npm_global_install_result,dedup_missing_bins,remove_npm_global_uninstall_links,read_npm_package_json,collect_bin_names_from_npm), all suppressingclippy::disallowed_typesand/orclippy::disallowed_macros.But
main.rsalready suppresses those lints for the whole crate:A crate-level inner
#![allow(...)]propagates to all descendant modules (dispatch.rsis one), so the per-fn attributes are dead. They lingered becauseclippy::allow_attributes— the lint that would flag a redundant#[allow]— is itself crate-allowed.