docs(global-cli): correct stale delegation comments - #2236
Merged
fengmk2 merged 4 commits intoAug 4, 2026
Merged
Conversation
👷 Deploy Preview for viteplus-preview processing.
|
✅ Deploy Preview for viteplus-preview canceled.
|
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.52 MiB | 10.52 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.55 MiB | 4.55 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 33.61 MiB | 33.61 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 13.02 MiB | 13.02 MiB | +1 B (+0.00%) |
vp (macOS ARM64) |
Binary | 7.84 MiB | 7.84 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.95 MiB | 3.95 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 40.92 MiB | 40.92 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 17.24 MiB | 17.24 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 8.42 MiB | 8.42 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.67 MiB | 3.67 MiB | +1 B (+0.00%) |
| NAPI (Windows x64) | Binary | 27.77 MiB | 27.77 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.86 MiB | 10.86 MiB | -1 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | +2 B (+0.00%) |
| Installer (Windows x64) | Binary | 4.47 MiB | 4.47 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.09 MiB | 2.09 MiB | 0 B (0.00%) |
Member
|
@shulaoda need to fix conflicts first. |
…n_comments_and_run_exec_help_hint # Conflicts: # crates/vite_global_cli/src/help.rs
shulaoda
force-pushed
the
07-25-fix_global-cli_correct_stale_delegation_comments_and_run_exec_help_hint
branch
from
August 3, 2026 18:33
50e1a88 to
d51d23b
Compare
shulaoda
changed the title
shulaoda
changed the title
Member
Author
|
It seems the related logic has been removed or refactored, so I’ve only kept the comment changes. |
fengmk2
approved these changes
Aug 4, 2026
…n_comments_and_run_exec_help_hint
…n_comments_and_run_exec_help_hint
fengmk2
deleted the
07-25-fix_global-cli_correct_stale_delegation_comments_and_run_exec_help_hint
branch
August 4, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two outdated bits in the global CLI, no behaviour change beyond the help string:
1. Stale "stubs" comments (
cli.rs)The Category C (local-CLI delegation) commands were commented as
(stubs for now)/(stubs), but every arm fully forwards to the local vite-plus CLI viacommands::delegate::execute— they are real, working delegations, not placeholders. Both comments now read(forwarded to the local vite-plus CLI).2. Misleading run/exec help hint (help.rs)The
runandexecdelegated help docs ended their options with:But
Run/Execare declared#[command(disable_help_flag = true)], and their help is printed by a single static doc —-hand--helpproduce identical output, so the "(see more with '--help')" hint is inaccurate copied clap boilerplate. The other nine delegated docs already use plainPrint help; run/exec now match.