Skip to content

feat: add support for .nvmrc as node version source - #2244

Merged
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
BlankParticle:feat/support-nvmrc
Aug 2, 2026
Merged

feat: add support for .nvmrc as node version source#2244
fengmk2 merged 3 commits into
voidzero-dev:mainfrom
BlankParticle:feat/support-nvmrc

Conversation

@BlankParticle

Copy link
Copy Markdown
Contributor

fixes #2207
adds .nvmrc as a supported source for node version resolution, behaviour is as discussed in the issue

implemented after discussion with @TheAlexLichter on voidzero discord (#2207 (comment))

thanks to @devmcclu who did a parallel implementation in #2213, i took some tests from that PR

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 688ba5a
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a6f430a157b98000849104f
😎 Deploy Preview https://deploy-preview-2244--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fengmk2 fengmk2 self-assigned this Jul 30, 2026
@fengmk2

fengmk2 commented Jul 30, 2026

Copy link
Copy Markdown
Member

@codex review

@fengmk2 fengmk2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlankParticle Thanks! LGTM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02d8536af5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_global_cli/src/cli.rs
Comment thread docs/guide/env.md Outdated
Comment thread docs/guide/env.md Outdated
@BlankParticle

Copy link
Copy Markdown
Contributor Author

thanks @TheAlexLichter for acting on the review, I saw it and was going to act on it but forgot to do so

@TheAlexLichter

Copy link
Copy Markdown
Member

thanks @TheAlexLichter for acting on the review, I saw it and was going to act on it but forgot to do so

Glad I could help 😋
please feel free to change anything to your liking!

@BlankParticle

Copy link
Copy Markdown
Contributor Author

thanks @TheAlexLichter for acting on the review, I saw it and was going to act on it but forgot to do so

Glad I could help 😋 please feel free to change anything to your liking!

things look fine, I just want this to get merged and released soon so I can stop using my local build of vite-plus 😄

@TheAlexLichter
TheAlexLichter requested a review from fengmk2 July 30, 2026 19:12
@fengmk2

fengmk2 commented Aug 2, 2026

Copy link
Copy Markdown
Member

@BlankParticle Thank you for your contribution, I will merge it and release it on Tuesday.

@fengmk2
fengmk2 merged commit b5f4bc5 into voidzero-dev:main Aug 2, 2026
45 checks passed
@BlankParticle
BlankParticle deleted the feat/support-nvmrc branch August 2, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support .nvmrc as a source for node version

3 participants