fix(output): print notes to stderr#2265
Open
wan9chi wants to merge 1 commit into
Open
Conversation
A note explains the situation around a command rather than being part of its result, so piping stdout to a file or a parser should not pick it up. Every current caller is prose for a human: `vp check`'s "Format skipped", the dlx yarn@1 fallback, "Version will be downloaded on first use", "Restart your terminal to apply shell changes". This is also what `rfcs/cli-output-polish.md` specified for `note` in both Rust and TypeScript; the implementation used `println!` instead.
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.31 MiB | 10.31 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.42 MiB | 4.42 MiB | -274 B (-0.01%) |
| NAPI (Linux x64) | Binary | 33.07 MiB | 33.07 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.72 MiB | 12.72 MiB | +59 B (+0.00%) |
vp (macOS ARM64) |
Binary | 7.64 MiB | 7.64 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.84 MiB | 3.84 MiB | +8 B (+0.00%) |
| NAPI (macOS ARM64) | Binary | 40.50 MiB | 40.50 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | +131 B (+0.00%) |
vp (Windows x64) |
Binary | 8.35 MiB | 8.34 MiB | -3.50 KiB (-0.04%) |
vp (Windows x64) |
gzip -9 | 3.64 MiB | 3.64 MiB | -344 B (-0.01%) |
| NAPI (Windows x64) | Binary | 27.51 MiB | 27.51 MiB | +512 B (+0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +67 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.44 MiB | 4.44 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | -1 B (-0.00%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
feat(cli): note when a built-in shares a name with a package.json script #2259, at the top of this stack, adds a note that has to reach an AI agent capturing piped output while leaving machine-readable stdout alone (
oxlint -f json,vitest --reporter=jsonandoxfmt --stdin-filepathall puttheir payload on stdout). Gating that note on a TTY would hide it from some ai agents; printing it to stdout would corrupt those payloads. Moving
noteto stderr resolves both.This is also what
rfcs/cli-output-polish.mdspecified fornotein both Rustand TypeScript — the implementation incorrectly used
println!.