refactor(cli): generate Zed language settings from a language list - #2294
Merged
fengmk2 merged 1 commit intoAug 2, 2026
Merged
Conversation
Replace 17 verbatim-identical per-language blocks in ZED_SETTINGS.languages with a language-name array mapped through Object.fromEntries. Only the JavaScript entry differs (code_action: source.fixAll.oxc), now expressed as a conditional spread. Generated .zed/settings.json output is byte-identical.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
naokihaba
approved these changes
Aug 2, 2026
naokihaba
left a comment
naokihaba
left a comment
Collaborator
There was a problem hiding this comment.
I considered if language-specific overrides might add overhead later, but since there's only one exception, this abstraction seems fine. It cleans up the duplication and makes shared updates much safer.
fengmk2
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZED_SETTINGS.languagesinpackages/cli/src/utils/editor.tslisted 17 per-language blocks that were verbatim-identical except for one key, so this PR replaces them with a language-name array mapped throughObject.fromEntries(88 lines down to 30).code_action: 'source.fixAll.oxc'on JavaScript) is now an explicit conditional spread instead of being hidden inside a wall of identical blocks.Behavior
No behavior change.
Object.fromEntriespreserves array order, so the generated.zed/settings.jsonis byte-identical, andZED_SETTINGSis consumed asRecord<string, unknown>so the weaker literal typing has no effect.