test(snapshots): kill vp before its children in env_install_interrupt - #2299
Merged
fengmk2 merged 1 commit intoAug 3, 2026
Merged
Conversation
fengmk2
force-pushed
the
fix-env-install-interrupt-kill-order
branch
from
August 3, 2026 02:49
02ec41b to
a7fb978
Compare
fengmk2
marked this pull request as ready for review
August 3, 2026 02:49
fengmk2
force-pushed
the
fix-env-install-interrupt-kill-order
branch
from
August 3, 2026 03:57
a7fb978 to
764dec7
Compare
cpojer
approved these changes
Aug 3, 2026
taskkill /T terminates the process tree in unspecified order. When the postinstall child dies before vp.exe, vp treats the reinstall as failed and removes the partial install dir, so no stale dir is left for the check-stale step and the case fails with "interrupted stale package removed". Kill vp.exe first so it cannot react to the dying child, then sweep the orphaned installer children. Claude-Session: https://claude.ai/code/session_01Q33nALG7fPwXJ3Ltp5DYku
fengmk2
force-pushed
the
fix-env-install-interrupt-kill-order
branch
from
August 3, 2026 05:00
764dec7 to
e0ca486
Compare
fengmk2
added a commit
that referenced
this pull request
Aug 4, 2026
On Windows, `vp` on PATH is the trampoline in VP_HOME/bin, which runs current/bin/vp.exe as a child and waits. The interrupt driver's child.pid was the trampoline, so the kill order from #2299 killed the wrong process first: the real vp.exe was torn down by `taskkill /T`, which kills the tree in unspecified order. Whenever the npm subtree died before vp.exe, the still-alive vp treated the reinstall as failed and removed the partial install dir that the check-stale step asserts on. When child enumeration returned nothing, only the trampoline died and the real vp survived as an orphan, matching the observed zero-output timeout mode. Unix never flaked because bin/vp is a symlink, so the killed child is the installer. Spawn VP_HOME/current/bin/vp directly so child.pid is the process that runs the install on every platform, and kill the postinstall subtree via a PID handshake in the ready file instead of PowerShell/CIM enumeration. Stage markers and a 45s watchdog make any future failure name the stage that hung instead of leaving a blank PTY screen.
fengmk2
added a commit
that referenced
this pull request
Aug 4, 2026
On Windows, `vp` on PATH is the trampoline in VP_HOME/bin, which runs current/bin/vp.exe as a child and waits. The interrupt driver's child.pid was the trampoline, so the kill order from #2299 killed the wrong process first: the real vp.exe was torn down by `taskkill /T`, which kills the tree in unspecified order. Whenever the npm subtree died before vp.exe, the still-alive vp treated the reinstall as failed and removed the partial install dir that the check-stale step asserts on. When child enumeration returned nothing, only the trampoline died and the real vp survived as an orphan, matching the observed zero-output timeout mode. Unix never flaked because bin/vp is a symlink, so the killed child is the installer. Spawn VP_HOME/current/bin/vp directly so child.pid is the process that runs the install on every platform, and kill the postinstall subtree via a PID handshake in the ready file instead of PowerShell/CIM enumeration. Stage markers and a 45s watchdog make any future failure name the stage that hung instead of leaving a blank PTY screen.
fengmk2
added a commit
that referenced
this pull request
Aug 4, 2026
…2316) The Windows `env_install_interrupt` case kept flaking after #2283 and #2299, in two modes: the check-stale step reported "interrupted stale package removed" instead of "exists", and a 60s zero-output step timeout. Root cause: on Windows, `vp` on PATH is the trampoline in `VP_HOME/bin`, which runs `current/bin/vp.exe` as a child and waits. The interrupt driver's `child.pid` was the trampoline, so #2299 killed the wrong process first. The real vp.exe was then torn down by `taskkill /T`, which kills the tree in unspecified order; whenever the npm subtree died before vp.exe, the still-alive vp treated the reinstall as failed and removed the partial install dir the test asserts on. When child enumeration returned nothing, only the trampoline died and the real vp survived as an orphan, matching the zero-output mode. Unix never flaked because `bin/vp` is a symlink, so the killed child is the installer. Fix, all inside the fixture: - Spawn `VP_HOME/current/bin/vp[.exe]` directly so `child.pid` is the process that runs the install on every platform; killing it first now prevents the cleanup reaction. - Kill the postinstall subtree via a PID handshake: postinstall writes its PID into the ready file (write-then-rename), so the driver needs no PowerShell/CIM enumeration. The npm layers in between exit on their own once the script dies, and with vp already dead nobody reacts. - Add stage markers and a 45s watchdog so a future failure names the stage that hung instead of showing a blank PTY screen. Verified on macOS with `cargo test -p vite_cli_snapshots -- env_install_interrupt`; the Windows race itself can only be exercised by this PR's Windows CLI snapshot leg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
env_install_interruptPTY snapshot fails intermittently on Windows:Example failure: https://github.com/voidzero-dev/vite-plus/actions/runs/30777846280/job/91576844864?pr=2297
taskkill /T /Fterminates the process tree in unspecified order. When the postinstall child dies beforevp.exe, vp observes the failed npm child and runscleanup_failed_install, removing the partial install dir before taskkill reaches vp itself, so no stale dir is left for the check-stale step. Reproduced the mechanism on macOS by killing the postinstall child first and letting vp react: same diff as the CI failure.Fix: enumerate vp's direct children while the tree is parked in the postinstall sleep, kill
vp.exefirst so it cannot react, thentaskkill /Teach orphaned child (killing vp alone would leave the installer children running). The Unix path and the recorded snapshot are unchanged.Stacked on #2297.