feat(pm): verify bun platform tarball against dist.integrity - #2310
Merged
Conversation
The packageManager hash names the main bun npm package, so the platform tarball was downloaded unverified. Extract the registry dist.integrity lookup already used by the pnpm >= 12 native path into a shared helper and apply it to the bun platform package as well. Reworks voidzero-dev#2301 on top of the pm-cli consolidation (voidzero-dev#2140).
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
August 3, 2026 10:38
fengmk2
approved these changes
Aug 3, 2026
fengmk2
added
test: e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-does #2301 on top of the pm-cli consolidation (#2140), which moved
vite_install/src/package_manager.rsintocrates/vite_pm_cliand made the old branch unrebaseable.packageManagerhash names the mainbunnpm package, so the platform tarball (@oven/bun-{os}-{arch}) was downloaded without any verification.dist.integritylookup that the pnpm >= 12 native path already implements inline into a sharedfetch_platform_integrityhelper, and applies it to the bun platform tarball as well.Supersedes #2301.