refactor(env): rename remaining Vite+ environment variables - #2312
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
The |
It is read in vite-plus/packages/cli/binding/src/cli/mod.rs Lines 460 to 480 in d1183bd |
Here, we are just reading |
|
I couldn't find anywhere in the repository that sets it either. It appears to be intended as a developer flag. Should we remove it? 🤔 |
Sure, go ahead and delete it with a new PR. cc @wan9chi |
|
Renamed |
Summary
This follows up on #1166, which renamed
VITE_PLUS_*environment variables to use theVP_*prefix. It applies thesame convention to the remaining Vite+-specific variables:
VITE_LOG,VITE_GLOBAL_CLI_JS_SCRIPTS_DIR, andVITE_UPDATE_TASK_TYPES, without retaining compatibility aliases.Resolves #2206