chore(deps): declare @emnapi peers where @napi-rs/cli is used - #2319
Merged
fengmk2 merged 1 commit intoAug 4, 2026
Merged
Conversation
@napi-rs/cli 3.8.2 requires peer @emnapi/runtime@2.0.0-alpha.3 exactly, but the root, packages/cli, and packages/core manifests declared only @napi-rs/cli, so pnpm filled the peer with the transitive 1.11.2 from @napi-rs/wasm-runtime@0.2.12 and warned about missing/conflicting peers on every install. Declare @emnapi/core and @emnapi/runtime from the catalog (already pinned to 2.0.0-alpha.3), mirroring what rolldown/packages/rolldown and rolldown/packages/browser already do.
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
Aug 4, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@napi-rs/cli@3.8.2requires the peer@emnapi/runtime@2.0.0-alpha.3exactly, but the root,packages/cli, andpackages/coremanifests declare only@napi-rs/cli. pnpm fills the missing peer with the transitive@emnapi/runtime@1.11.2, which violates the exact pin, so everypnpm installprints a missing/conflicting-peer warning block.This declares
@emnapi/coreand@emnapi/runtimeas devDependencies (catalog-pinned to2.0.0-alpha.3) in the three manifests, mirroringrolldown/packages/rolldown. Re-resolution also dedupes the bogus1.11.2peer variants from the lockfile.Before:
After:
Test plan
pnpm install— @emnapi warning block no longer appears