chore(shared): remove unused EnvConfig fields - #2320
Merged
fengmk2 merged 2 commits intoAug 4, 2026
Conversation
Remove bypass_shim, debug_shim, tool_recursion, js_scripts_dir, and update_task_types. Every consumer reads the corresponding env var directly, and VP_BYPASS/VP_TOOL_RECURSION are mutated mid-process by shim dispatch, so a startup snapshot could never serve them anyway.
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jong-kyung
marked this pull request as ready for review
August 4, 2026 11:50
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five
EnvConfigfields (bypass_shim,debug_shim,tool_recursion,js_scripts_dir,update_task_types) appear to be unused — no reads anywhere in the repo; every consumer reads the env var directly. The env vars themselves keep working as before.If these are used somewhere I missed, happy to restore.
Test plan
cargo check --workspace/cargo test -p vite_shared