chore(deps): exclude rollup-tests from workspace, update basic-ftp - #2322
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Exclude rolldown/packages/rollup-tests (rolldown's rollup compat suite, unused by vite-plus) from the pnpm workspace and remove its now-unused rollup-tests catalog. sync-remote-deps keeps both edits on future syncs. Also bump transitive basic-ftp 5.0.5 -> 5.3.1 within get-uri's ^5 range; 5.0.5 is deprecated with a security fix in 5.2.1. vp install deprecation warnings drop from 8 subdependencies plus the rollup-tests importer warning to 4.
fengmk2
force-pushed
the
chore/exclude-rollup-tests
branch
from
August 4, 2026 12:35
f0decb6 to
ab5f8de
Compare
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.52 MiB | 10.52 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.55 MiB | 4.55 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 33.66 MiB | 33.66 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 13.05 MiB | 13.05 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.84 MiB | 7.84 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.96 MiB | 3.96 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 40.95 MiB | 40.95 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 17.26 MiB | 17.26 MiB | +21 B (+0.00%) |
vp (Windows x64) |
Binary | 8.43 MiB | 8.43 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.67 MiB | 3.67 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | Binary | 27.81 MiB | 27.81 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.88 MiB | 10.88 MiB | -2 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.46 MiB | 4.46 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.09 MiB | 2.09 MiB | 0 B (0.00%) |
TheAlexLichter
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes
rolldown/packages/rollup-tests(rolldown's rollup compat suite, unused by vite-plus) from the pnpm workspace and removes its now-unusedrollup-testscatalog.sync-remote-depspreserves both edits on future syncs: the packages merge starts from our list and named catalogs are never merged.Also bumps transitive
basic-ftp5.0.5 -> 5.3.1 withinget-uri's^5range. 5.0.5 is deprecated with a security fix in 5.2.1.vp installbefore:after:
The remaining 4 are out of semver range for their dependents (wdio chain, stylus, jsdom, parse-url) and wait on upstream updates. Verified with
pnpm installandpnpm install --frozen-lockfile.