fix(test): emit NodeNext-compatible provider type specifiers - #2360
Merged
fengmk2 merged 2 commits intoAug 6, 2026
Merged
Conversation
Co-authored-by: GPT-5.6 Codex <codex@openai.com>
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
added
test: e2e
fengmk2
approved these changes
Aug 6, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jsextensions for relative shim specifiers in inlined browser-provider declarations so they resolve under NodeNext.vite-plus/test/browser-playwrighttypes export.Fixes #2354
Validation
pnpm --filter vite-plus test src/__tests__/exports-map.spec.tsvp checkpnpm run checkandpnpm run typecheckin the public reproduction using a locally packed Vite+ build