fix(config): skip git lookup when hooks are disabled - #2458
Merged
fengmk2 merged 1 commit intoAug 15, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
Aug 15, 2026
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
vp confignow checks the Git hooks environment opt-out before resolving the hook location. WithHUSKY=0,VP_GIT_HOOKS=0, or the legacyVITE_GIT_HOOKS=0, it skips hook setup without invoking Git.Why
The opt-out previously lived inside
install(), butvp configcalled the Git-backed location resolver first. Git-less containers therefore failed even though hooks were explicitly disabled.Tests
Fixes #2441