Skip to content

ci: prevent vite-plus to be built twice#305

Merged
Brooooooklyn merged 1 commit intomainfrom
11-13-ci_prevent_vite-plus_to_be_built_twice
Nov 14, 2025
Merged

ci: prevent vite-plus to be built twice#305
Brooooooklyn merged 1 commit intomainfrom
11-13-ci_prevent_vite-plus_to_be_built_twice

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings November 13, 2025 13:23
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Nov 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the CI build process by eliminating redundant builds of the @voidzero-dev/vite-plus package. The key improvement is that the CI workflow now uses bootstrap-cli:ci which skips building vite-plus since it's already built by the build-upstream action.

Key Changes:

  • Removed duplicate vite-plus build step from CI by using bootstrap-cli:ci instead of bootstrap-cli
  • Removed obsolete copy-bindings script (the vite-plus build process already handles copying bindings to its dist directory)
  • Standardized package manager usage by changing npm install to pnpm install in the install-global-cli script

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updated bootstrap-cli to remove redundant vite-plus build, removed obsolete copy-bindings script, and standardized to use pnpm for global CLI installation
.github/workflows/ci.yml Modified CI jobs to use bootstrap-cli:ci instead of bootstrap-cli to avoid rebuilding vite-plus after build-upstream action already builds it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-13-ci_prevent_vite-plus_to_be_built_twice branch from 9251182 to e68a67c Compare November 13, 2025 13:47
Copy link
Copy Markdown
Member Author

Brooooooklyn commented Nov 14, 2025

Merge activity

  • Nov 14, 5:07 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 5:08 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 67d255a into main Nov 14, 2025
12 checks passed
@Brooooooklyn Brooooooklyn deleted the 11-13-ci_prevent_vite-plus_to_be_built_twice branch November 14, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants