ci: prevent vite-plus to be built twice#305
Merged
Brooooooklyn merged 1 commit intomainfrom Nov 14, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the CI build process by eliminating redundant builds of the @voidzero-dev/vite-plus package. The key improvement is that the CI workflow now uses bootstrap-cli:ci which skips building vite-plus since it's already built by the build-upstream action.
Key Changes:
- Removed duplicate vite-plus build step from CI by using
bootstrap-cli:ciinstead ofbootstrap-cli - Removed obsolete
copy-bindingsscript (the vite-plus build process already handles copying bindings to its dist directory) - Standardized package manager usage by changing
npm installtopnpm installin theinstall-global-cliscript
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated bootstrap-cli to remove redundant vite-plus build, removed obsolete copy-bindings script, and standardized to use pnpm for global CLI installation |
| .github/workflows/ci.yml | Modified CI jobs to use bootstrap-cli:ci instead of bootstrap-cli to avoid rebuilding vite-plus after build-upstream action already builds it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9251182 to
e68a67c
Compare
branchseer
approved these changes
Nov 14, 2025
fengmk2
approved these changes
Nov 14, 2025
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.