fix(cli): re-export * from vitest by Brooooooklyn · Pull Request #306 · voidzero-dev/vite-plus

Brooooooklyn · 2025-11-13T13:44:37Z

No description provided.

Brooooooklyn · 2025-11-13T13:44:54Z

fix(cli): re-export * from vitest #306 👈 (View in Graphite)
ci: prevent vite-plus to be built twice #305
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR refactors the CLI to properly re-export Vite and Vitest functionality while introducing a dedicated config module. The main goal is to separate config-related exports into their own entry point (/config) to improve modularity.

Key changes:

Introduces a new ./config export path that provides defineConfig and module augmentation for custom lint/fmt options
Restructures index.ts to explicitly re-export specific Vite types and functions instead of using wildcard exports
Filters out vitest's ./config export to prevent conflicts with the custom config implementation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vite.config.ts	Updates import path to use the new `/config` export
packages/tools/src/sync-remote-deps.ts	Adds `./config` to CLI-owned exports and filters it from vitest exports to prevent conflicts
packages/cli/src/index.ts	Restructures exports to explicitly list Vite types/functions and adds Vitest test exports
packages/cli/src/config.ts	New config module that augments Vite's UserConfig with lint/fmt options and re-exports vitest config
packages/cli/package.json	Updates `./config` export to point to the new config module
packages/cli/build.ts	Adds config.ts to build inputs, updates externals, adds renderChunk hook for rolldown imports, and updates vite module declaration rewriting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fengmk2 · 2025-11-19T05:59:30Z

@@ -1,4 +1,4 @@
-import { defineConfig } from '@voidzero-dev/vite-plus';
+import { defineConfig } from '@voidzero-dev/vite-plus/config';


Is exporting defineConfig from /config the final solution?

not sure... let's test in more repos

Brooooooklyn mentioned this pull request Nov 13, 2025

ci: prevent vite-plus to be built twice #305

Merged

Brooooooklyn force-pushed the 11-13-fix_cli_re-export_from_vitest branch from f7ab1ca to 5c3a1ae Compare November 13, 2025 13:47

Brooooooklyn force-pushed the 11-13-ci_prevent_vite-plus_to_be_built_twice branch from 9251182 to e68a67c Compare November 13, 2025 13:47

Brooooooklyn changed the base branch from 11-13-ci_prevent_vite-plus_to_be_built_twice to graphite-base/306 November 14, 2025 05:08

Brooooooklyn force-pushed the 11-13-fix_cli_re-export_from_vitest branch from 5c3a1ae to ddae522 Compare November 14, 2025 05:08

Brooooooklyn force-pushed the graphite-base/306 branch from e68a67c to 67d255a Compare November 14, 2025 05:08

graphite-app Bot changed the base branch from graphite-base/306 to main November 14, 2025 05:09

Brooooooklyn force-pushed the 11-13-fix_cli_re-export_from_vitest branch from ddae522 to 49fedfe Compare November 14, 2025 05:09

Copilot AI review requested due to automatic review settings November 14, 2025 06:42

Copilot started reviewing on behalf of Brooooooklyn November 14, 2025 06:43 View session

Copilot finished reviewing on behalf of Brooooooklyn November 14, 2025 06:45

Copilot AI reviewed Nov 14, 2025

View reviewed changes

Comment thread packages/cli/build.ts

Comment thread packages/cli/src/index.ts

Comment thread packages/cli/src/config.ts

Brooooooklyn added 3 commits November 14, 2025 16:57

fix(cli): re-export * from vitest

41d9560

fix types

8073db3

fix types

e6cbb9f

Copilot AI review requested due to automatic review settings November 14, 2025 08:57

Brooooooklyn force-pushed the 11-13-fix_cli_re-export_from_vitest branch from d3437f0 to e6cbb9f Compare November 14, 2025 08:57

Copilot started reviewing on behalf of Brooooooklyn November 14, 2025 08:57 View session

Copilot finished reviewing on behalf of Brooooooklyn November 14, 2025 08:59

Copilot AI reviewed Nov 14, 2025

View reviewed changes

Comment thread packages/cli/src/config.ts

Brooooooklyn added 2 commits November 15, 2025 22:40

update upstream

20ce87b

align rolldown & rolldown-vite

20ec8e5

Copilot AI review requested due to automatic review settings November 17, 2025 02:16

Copilot started reviewing on behalf of Brooooooklyn November 17, 2025 02:16 View session

Copilot finished reviewing on behalf of Brooooooklyn November 17, 2025 02:17

Copilot AI reviewed Nov 17, 2025

View reviewed changes

Comment thread packages/cli/src/config.ts

Comment thread packages/cli/build.ts

Comment thread packages/cli/src/index.ts Outdated

Brooooooklyn added 2 commits November 17, 2025 11:30

add missing exports

af994ad

update snap

2ece52c

Copilot AI review requested due to automatic review settings November 17, 2025 04:46

Copilot AI reviewed Nov 18, 2025

View reviewed changes

Comment thread packages/cli/src/resolve-lint.ts Outdated

Comment thread packages/cli/src/resolve-lint.ts Outdated

Comment thread packages/cli/package.json

Comment thread packages/cli/tsconfig.json Outdated

Brooooooklyn added 2 commits November 18, 2025 22:16

Fix lint

e633946

Update snapshot

b1164a6

Copilot AI review requested due to automatic review settings November 18, 2025 14:42

Copilot started reviewing on behalf of Brooooooklyn November 18, 2025 14:43 View session

Copilot finished reviewing on behalf of Brooooooklyn November 18, 2025 14:44

Copilot AI reviewed Nov 18, 2025

View reviewed changes

Comment thread packages/cli/package.json

Comment thread packages/cli/build.ts

Comment thread packages/cli/snap-tests/command-doc/steps.json

Brooooooklyn added 2 commits November 19, 2025 10:32

Update snapshot

1420c55

fix vitest build on Windows

f9b453f

Copilot AI review requested due to automatic review settings November 19, 2025 04:00

Copilot started reviewing on behalf of Brooooooklyn November 19, 2025 04:00 View session

Copilot finished reviewing on behalf of Brooooooklyn November 19, 2025 04:03

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Comment thread packages/cli/src/resolve-lint.ts Outdated

Comment thread pnpm-workspace.yaml

Brooooooklyn added 2 commits November 19, 2025 12:16

fmt

3687088

resolve bin path

255a9dc

Copilot AI review requested due to automatic review settings November 19, 2025 04:21

Copilot started reviewing on behalf of Brooooooklyn November 19, 2025 04:21 View session

Copilot finished reviewing on behalf of Brooooooklyn November 19, 2025 04:26

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Comment thread package.json

Comment thread packages/tools/src/sync-remote-deps.ts

Comment thread packages/cli/src/config.ts

Comment thread packages/cli/src/resolve-lint.ts Outdated

Brooooooklyn added 2 commits November 19, 2025 13:08

relative path

54ad84e

relative path

23f3e10

Copilot AI review requested due to automatic review settings November 19, 2025 05:20

Copilot started reviewing on behalf of Brooooooklyn November 19, 2025 05:20 View session

Copilot finished reviewing on behalf of Brooooooklyn November 19, 2025 05:23

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Comment thread packages/cli/package.json

Comment thread packages/cli/src/resolve-lint.ts

Brooooooklyn merged commit 639b341 into main Nov 19, 2025
17 of 18 checks passed

Brooooooklyn deleted the 11-13-fix_cli_re-export_from_vitest branch November 19, 2025 05:55

fengmk2 reviewed Nov 19, 2025

View reviewed changes

Comment thread package.json

fengmk2 approved these changes Nov 19, 2025

View reviewed changes

fengmk2 reviewed Nov 19, 2025

View reviewed changes

		@@ -1,4 +1,4 @@
		import { defineConfig } from '@voidzero-dev/vite-plus';
		import { defineConfig } from '@voidzero-dev/vite-plus/config';

Conversation

Brooooooklyn commented Nov 13, 2025

Uh oh!

Brooooooklyn commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brooooooklyn Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Brooooooklyn commented Nov 13, 2025 •

edited

Loading

fengmk2 Nov 19, 2025 •

edited

Loading