fix: should not download binding to dist#436
Merged
Merged
Conversation
Brooooooklyn
approved these changes
Jan 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect workflow configuration where native bindings were being downloaded to both the dist and artifacts directories for the global package, when they should only go to artifacts.
Changes:
- Removed the redundant download step that placed global native bindings in the
distdirectory - Aligns the global package's artifact handling with the CLI package's pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
some package missing native binary |
fengmk2
force-pushed
the
remove-native-files-before-release
branch
from
6148fa2 to
ab0b085
Compare
fengmk2
commented
Jan 15, 2026
Member
Author
Member
Author
|
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.