DEP: move dependency specs to static metadata #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
3 times, most recently
from
a721c43 to
e478a1e
Compare
neutrinoceros
commented
Jul 30, 2025
IainHammond
reviewed
Jul 30, 2025
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
from
ddfa5e0 to
033c2b0
Compare
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
2 times, most recently
from
16b08d2 to
88c9726
Compare
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
2 times, most recently
from
ad595fe to
9cd5d15
Compare
Contributor
Author
|
This is now based off #672 |
Contributor
Author
|
Hitting ABI incompatibilities between numpy 2.0.2 and astropy 6.0.1 that prevent testing on 3.9. I could work around that but if my proposal to drop 3.9 from #675 is accepted, there's not much point adding emphemeral complexity here. |
neutrinoceros
commented
Aug 2, 2025
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
from
5d4c903 to
d110796
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
===========================================
- Coverage 62.28% 32.93% -29.36%
===========================================
Files 11 87 +76
Lines 928 16833 +15905
===========================================
+ Hits 578 5543 +4965
- Misses 350 11290 +10940 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
from
4d84a21 to
efe68ad
Compare
neutrinoceros
force-pushed
the
dep/static-deps-metadata
branch
from
efe68ad to
4a8c0be
Compare
Contributor
|
Thanks a lot @neutrinoceros - this looks good ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off #670
I originally said I would only do this if requested but I changed my mind and thought it might be more compelling to show a concrete implementation of my proposal.