MNT: migrate package layout from flat to src #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hum, actually, it might also require #671 goes in first. Will keep this one as a draft for now |
neutrinoceros
force-pushed
the
mnt/src-layout
branch
4 times, most recently
from
a4c9761 to
91c4754
Compare
Contributor
neutrinoceros
force-pushed
the
mnt/src-layout
branch
from
91c4754 to
91a38af
Compare
Contributor
Author
|
rebased. Let's this what happens now. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 28.65% 0.00% -28.65%
==========================================
Files 87 87
Lines 16833 16836 +3
==========================================
- Hits 4822 0 -4822
- Misses 12011 16836 +4825 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
should be good now |
Contributor
|
Thanks a lot @neutrinoceros ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #670, where we saw multiple issues with testing surfacing that were symptoms of CI running tests again the source tree instead of a built package. Using a "src-layout" makes this situation much less likely to happen. I'm going to do this change in two commits, where the first one will be moving all source files, which is expected to fail CI, and in the second one I'll adapt CI, resolving the core issue.