Skip to content

Remove EmbeddedRenderer section. - #58

Merged
dmitrizagidulin merged 1 commit into
mainfrom
remove-embedded-renderer
Aug 11, 2026
Merged

Remove EmbeddedRenderer section.#58
dmitrizagidulin merged 1 commit into
mainfrom
remove-embedded-renderer

Conversation

@dmitrizagidulin

@dmitrizagidulin dmitrizagidulin commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Removes the EmbeddedRenderer method section, per the group consensus on the previous several calls (due to Phone Home concerns).


Preview | Diff

Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
@iherman

iherman commented Jul 29, 2026

Copy link
Copy Markdown
Member

Didn'd we also say that there is no reason to keep the concept of a TemplateRenderer anymore as a result of this change?

@isaackps

Copy link
Copy Markdown
Collaborator

Hi,

I have missed the point of removing this embeddedRenderer, can i find out what is the main reason for doing so?

@msporny

msporny commented Aug 9, 2026

Copy link
Copy Markdown
Member

@isaackps wrote:

I have missed the point of removing this embeddedRenderer, can i find out what is the main reason for doing so?

Hey Isaac, yes, the main reason is that the HTML template renderer provides the same functionality without the phone-home concerns and information leakage concerns. We expect that when we attempt to do the horizontal review at W3C (which we hope to kick off in the next several weeks), that the privacy and security reviews will not allow this mechanism to proceed, thus blocking the entire specification from proceeding.

We can document it as a mechanism that has been deployed, but I think the WG is likely to determine that the approach shouldn't be used since the HTML-based render method is equivalent without the privacy/phone-home concerns. That said, I hope that we have provided an alternative mechanism that your implementations could upgrade to (there is nothing to say that the rendering must happen on the client, but we wanted to make sure it was possible to do so w/o a server and in a completely sandboxed, no networking environment).

Did that answer your question, @isaackps?

@msporny

msporny commented Aug 9, 2026

Copy link
Copy Markdown
Member

@iherman wrote:

Didn'd we also say that there is no reason to keep the concept of a TemplateRenderer anymore as a result of this change?

Hmm, I may be misunderstanding, but no, we still need TemplateRenderMethod for card, nfc, and html.

@iherman

iherman commented Aug 10, 2026

Copy link
Copy Markdown
Member

@iherman wrote:

Didn'd we also say that there is no reason to keep the concept of a TemplateRenderer anymore as a result of this change?

Hmm, I may be misunderstanding, but no, we still need TemplateRenderMethod for card, nfc, and html.

...and I'm not convinced that we need an extra class layer between RenderMethod and the one you mention.

@isaackps

Copy link
Copy Markdown
Collaborator

@isaackps wrote:

I have missed the point of removing this embeddedRenderer, can i find out what is the main reason for doing so?

Hey Isaac, yes, the main reason is that the HTML template renderer provides the same functionality without the phone-home concerns and information leakage concerns. We expect that when we attempt to do the horizontal review at W3C (which we hope to kick off in the next several weeks), that the privacy and security reviews will not allow this mechanism to proceed, thus blocking the entire specification from proceeding.

We can document it as a mechanism that has been deployed, but I think the WG is likely to determine that the approach shouldn't be used since the HTML-based render method is equivalent without the privacy/phone-home concerns. That said, I hope that we have provided an alternative mechanism that your implementations could upgrade to (there is nothing to say that the rendering must happen on the client, but we wanted to make sure it was possible to do so w/o a server and in a completely sandboxed, no networking environment).

Did that answer your question, @isaackps?

@msporny Thanks for the explanation, understand about the phone-home concerns and will look into the equivalent HTML-based render method. 👍

@msporny

msporny commented Aug 11, 2026

Copy link
Copy Markdown
Member

@isaackps wrote:
@msporny Thanks for the explanation, understand about the phone-home concerns and will look into the equivalent HTML-based render method. 👍

Great, thank you @isaackps -- and more specifically, if it doesn't work for your needs, please let the group know as quickly as you can so we can fix it. We are trying to get into feature freeze for this specification within the next several weeks.

@dmitrizagidulin

Copy link
Copy Markdown
Collaborator Author

Thanks @isaackps! (merging this PR)

@iherman we can discuss the class hierarchy on today's call.

@dmitrizagidulin
dmitrizagidulin merged commit 6653516 into main Aug 11, 2026
1 of 2 checks passed
@dmitrizagidulin
dmitrizagidulin deleted the remove-embedded-renderer branch August 11, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants