Add completion spec: Vagrant (vagrant)

[warp-agent-staging]

Summary

Adds a hand-written completion spec for the vagrant CLI (HashiCorp Vagrant), closing the gap where signature_by_name("vagrant") returned None.

command-signatures/json/vagrant.json covers:

• All 36 top-level subcommands reported by vagrant list-commands: autocomplete, box, cloud, destroy, docker-exec, docker-logs, docker-run, global-status, halt, help, init, list-commands, login, package, plugin, port, powershell, provider, provision, push, rdp, reload, resume, rsync, rsync-auto, snapshot, ssh, ssh-config, status, suspend, up, upload, validate, version, winrm, winrm-config.
• Nested command groups: box (add/list/outdated/prune/remove/repackage/update/help), cloud (auth/box/provider/publish/search/version, including the third-level auth, box, provider and version leaves), plugin (install/license/list/uninstall/update/repair/expunge), snapshot (delete/list/pop/push/restore/save).
• Flags for every subcommand, with --foo / --no-foo pairs marked exclusiveOn each other, filepaths/folders templates on path arguments, and static value suggestions for providers, architectures, checksum types, shells, and sort/order enums.
• Global flags (--color/--no-color, --machine-readable, --debug, --timestamp, --debug-timestamp, --no-tty, -h, -v) marked isPersistent, since Vagrant accepts them at every subcommand level.

command-signatures/src/generators/vagrant.rs adds the two generators fish backs with dynamic helpers, registered in generators/mod.rs via dynamic_command_signature_data():

• vagrant_machines (fish's __fish_vagrant_machines) — walks up from the working directory for .vagrant/machines, then lists <machine>/<provider> two levels deep so each suggestion is described by the provider it was brought up with. Referenced by every subcommand that takes a [name|id] / [vm-name].
• vagrant_boxes (fish's __fish_vagrant_boxes) — lists the boxes directory under the Vagrant home (honoring $VAGRANT_HOME) and reverses Vagrant's -VAGRANTCOLON- / -VAGRANTSLASH- directory escaping, matching BoxCollection#undir_name. Referenced by init, box remove, box repackage, box update --box, and box prune --name.

Both generators read the filesystem rather than shelling out to vagrant status / vagrant box list: Vagrant is a Ruby program with a multi-second start-up, which is too slow to run on a completion keystroke. The layout they read is the one Vagrant itself writes — confirmed against Vagrant::Environment#active_machines and Vagrant::BoxCollection in 2.4.9 — and both degrade silently to no suggestions outside a Vagrant project / with no boxes installed.

Both are POSIX-only, like the other generators in this repo: they run a sh pipeline and produce no suggestions in a Windows shell. Windows support is deliberately out of scope here.

Deviations from the fish reference

• connect and share are in the fish commands list but are omitted: they were provided by the vagrant-share plugin, which is no longer shipped and does not appear in vagrant list-commands or vagrant --help on 2.4.9.
• cap appears in vagrant list-commands but is omitted as an internal capability-dispatch command, matching fish.
• autocomplete, list-commands, provider, upload, validate, plugin repair, and plugin expunge are added beyond the fish surface — they exist on current Vagrant.

Verification

./script/presubmit passes: npm run format:check, cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings, and cargo test (129 tests). That includes this repo's spec invariants — every generatorName resolves in dynamic_command_signature_data(), every JSON spec deserializes, and no generator command has an unquoted newline.

The spec content was verified against a real Vagrant 2.4.9 binary rather than written from memory: vagrant list-commands and vagrant <subcommand> -h were run for every subcommand and nested subcommand, and each flag, argument name, and description in the spec comes from that output.

14 tests live in vagrant.rs:

• test_vagrant_spec_covers_every_subcommand_and_nested_group — asserts signature_by_name("vagrant") resolves and exposes all 36 top-level subcommands plus every nested box / cloud / plugin / snapshot subcommand.
• parse_machines / parse_boxes unit coverage — provider descriptions, machines with no provider directory yet, multi-provider machines, non-listing lines, -VAGRANTSLASH- / -VAGRANTCOLON- un-escaping, blank lines, empty output.
• test_boxes_command_quotes_the_resolved_path — guards the quoting fix below.
• posix_execution::* — three tests that actually spawn the listings against on-disk fixtures, including a VAGRANT_HOME and a project path that contain spaces, plus a no-Vagrant-project case that must stay silent.

The quoted box path matters, and is reproducible directly:

$ VAGRANT_HOME="/tmp/spacetest/my vagrant home" sh -c 'ls -1 ${VAGRANT_HOME:-$HOME/.vagrant.d}/boxes'      # unquoted
ls: cannot access '/tmp/spacetest/my': No such file or directory
ls: cannot access 'vagrant': No such file or directory
ls: cannot access 'home/boxes': No such file or directory

$ VAGRANT_HOME="/tmp/spacetest/my vagrant home" sh -c 'ls -1 "${VAGRANT_HOME:-$HOME/.vagrant.d}/boxes"'    # as shipped
hashicorp-VAGRANTSLASH-bionic64
mybox

Verified in a real Warp session

warp-oss was built from a local warpdotdev/warp checkout with warp-command-signatures pointed at this branch, launched on a Linux desktop, and driven with the Tab key in /home/agent/vagrant-demo (a Vagrant project seeded with three machines and four installed boxes in the on-disk layout Vagrant writes). The screenshots below were re-captured from a rebuild of the final state of this branch.

vagrant up + Tab — vagrant_machines produces the three machine names, each described by its provider:

db        docker
default   virtualbox
web       libvirt

vagrant box remove + Tab — vagrant_boxes produces the four installed boxes, with -VAGRANTSLASH- un-escaped back to /:

generic/ubuntu2204     Installed box
hashicorp/bionic64     Installed box
mybox                  Installed box
ubuntu/jammy64         Installed box

vagrant + Tab lists the static subcommands with their descriptions.

Follow-up (required, after this merges)

warpdotdev/warp pins warp-command-signatures to a git rev in Cargo.toml / Cargo.lock, so vagrant completions will not reach the client until that rev is bumped. That bump is a separate PR against warpdotdev/warp (same pattern as warp#14742 for journalctl) and is deliberately not part of this change — it cannot be made until this PR merges.

Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785980828616589
Linear issue: https://linear.app/warpdotdev/issue/APP-3965/add-vagrant-completions
Source GitHub issue: warpdotdev/warp#9781

Computer-use screenshots (3)

Warp completions dropdown after typing 'vagrant up ' and pressing Tab, showing machine names db/default/web and flags.

Warp completions dropdown after typing 'vagrant box remove ' and pressing Tab, showing installed box names and --all flags.

Warp completions dropdown after typing 'vagrant ' and pressing Tab, showing subcommands autocomplete, box, cloud, destroy, docker-exec, docker-logs.

Conversation: https://staging.warp.dev/conversation/973d9e8f-7676-499c-a57b-933173040c1a
Run: https://oz.staging.warp.dev/runs/019fd4c8-89bf-7dfd-858c-3f34cb8c08e8

This PR was generated with Oz.

[oz-for-oss]

@warp-agent-staging[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

Adds Vagrant completion support through a new JSON spec plus Rust dynamic generators for local machines and installed boxes. The attached diff only includes the Rust generator/test changes; GitHub did not provide a patch for command-signatures/json/vagrant.json, so review of the spec content itself is limited to the PR description.

Concerns

• No blocking correctness, security, or spec-drift concerns found in the annotated diff.
• One non-blocking robustness suggestion is inline.

Verdict

Found: 0 critical, 0 important, 1 suggestions

Approve with nits

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz