Bundle Warp Agent CLI for Windows - #14444
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
58874da to
7870838
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds the Windows Warp Agent CLI packaging foundation: compact Cargo profiles, a TUI artifact path in the Windows bundle script, deterministic ZIP/symbol archive generation, signature/package validation hooks, and CI coverage for the packaging script.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
- No approved or repository spec context was provided for implementation comparison.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - name: Run PSScriptAnalyzer (PowerShell Lint) | ||
| run: ./script/lint_powershell -ci | ||
| shell: pwsh | ||
| - name: Test Windows TUI packaging |
There was a problem hiding this comment.
Do we need to add this to CI?
There was a problem hiding this comment.
[Warp Agent] Removed the Windows TUI packaging fixture from regular PR CI in commit fce90e948. Packaging remains covered by the explicitly dispatched Windows release workflow rather than every CI run.
| } | ||
|
|
||
| if target_os == "windows" { | ||
| println!("cargo:rerun-if-env-changed=CARGO_FULL_PROFILE"); |
There was a problem hiding this comment.
What's the motivation for this change?
There was a problem hiding this comment.
[Warp Agent] CARGO_FULL_PROFILE changes the target directory where build.rs copies Windows assets. Without rerun-if-env-changed, Cargo can reuse stale build-script output across profile changes. Added that rationale in commit fce90e948.
| 'stable' { 'WarpAgentCLI' } | ||
| 'oss' { 'WarpAgentCLIOss' } | ||
| } | ||
| $FEATURES = 'release_bundle,standalone' |
There was a problem hiding this comment.
Oh we don't need the nld classifier for TUI bundling?
There was a problem hiding this comment.
[Warp Agent] We do need it. Fixed in commit fce90e948: warp_tui now enables nld_classifier_v3 and nld_heuristic_v2, so the Windows TUI bundle includes the same NLD behavior.
7870838 to
fce90e9
Compare
fce90e9 to
0d065f9
Compare
## Description Build the Windows Warp Agent CLI as a signed Inno Setup installer instead of a portable ZIP. The installer follows Warp's GUI installation model for OS/architecture gating, private MSVC runtime dependencies, signed setup/uninstall components, and ARP registration. It keeps the CLI's immutable `versions/<version>` layout so upgrades do not replace executables used by active sessions, and preserves custom managed/bin roots and PATH opt-out through silent parameters. This is the replacement for reference PR #14444; that PR and branch are intentionally unchanged. Implementation plan: https://staging.warp.dev/drive/notebook/BI2TyxneCNDssiTUVIF0iK ## Linked Issue - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [ ] Where appropriate, screenshots or a short video of the implementation are included below. ## Testing - `./script/format` - `cargo check -p warp_tui --bin warp-tui-dev --features release_bundle,standalone,crash_reporting` - Repository-prescribed split Clippy checks - Added native Windows fixture coverage for silent install, rerun, v1-to-v2 upgrade while v1 is running, current/previous activation, ARP registration, custom paths with spaces, and uninstall - [ ] I have manually tested my changes locally with `./script/run` ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE Co-Authored-By: Warp <agent@warp.dev> Co-authored-by: Warp <agent@warp.dev>
1 participant
Description
Adds the local Windows build and bundle foundation for Warp Agent CLI:
script/bundlewith a TUI artifact path for x64 and arm64This is phase 1 of the Windows Warp Agent CLI release stack. Windows artifact publication remains intentionally disabled.
Conversation: https://staging.warp.dev/conversation/7b2fa858-09f9-47dd-8819-277acd3fa779
Linked Issue
No linked issue.
ready-to-specorready-to-implement.Testing
./script/formatrepository-required workspace, GUI-default, and completer Clippy invocations with
-D warningscomplete final-sha native CI passed: https://github.com/warpdotdev/warp-internal/actions/runs/30419318109
credentialed build, signing, deterministic payload/symbol packaging, isolated launch, packaged ConPTY smoke, and workflow artifact upload passed: https://github.com/warpdotdev/warp-internal/actions/runs/30419349007
package scripts include x64/arm64 shape, deterministic archive, malformed input, and isolated runtime checks
I have manually tested my changes locally with
./script/runAgent Mode
CHANGELOG-NONE