Build Windows Warp Agent CLI in dev releases - #14445
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c0cec5e to
90f8877
Compare
58874da to
7870838
Compare
753b488 to
3982b28
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a dev-only Windows x64 TUI/Agent CLI release job, wires Windows channel-config installation into release dependency setup, adds package inspection and ConPTY smoke coverage, and retries Windows shell creation without breakaway when job-contained hosts deny it.
Concerns
- No blocking concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
7870838 to
fce90e9
Compare
3982b28 to
9af5dfb
Compare
9af5dfb to
7fa5f45
Compare
fce90e9 to
0d065f9
Compare
## Description Add a dev-only Windows x64 release job for the Warp Agent CLI Inno installer. The job builds the real CLI, signs the CLI and Windows runtime payloads with Azure Trusted Signing, signs the setup engine and uninstaller, and uploads the installer and raw PDB as workflow artifacts. Inno signing setup is shared with the existing Windows GUI release job. Artifact publication remains intentionally disabled. This replaces reference PR #14445 without modifying it. Depends on #14475. Implementation plan: https://staging.warp.dev/drive/notebook/BI2TyxneCNDssiTUVIF0iK ## Linked Issue - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [ ] Where appropriate, screenshots or a short video of the implementation are included below. ## Testing - `./script/format` - Repository-prescribed split Clippy checks - `cargo check -p warp --lib` - Release workflow validates the installer fixture, real signed build, shared Inno signing setup, and installer/raw-PDB artifact output - Credentialed non-publishing release validation will be linked after this branch is remotely exercised - [ ] I have manually tested my changes locally with `./script/run` ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE Co-Authored-By: Warp <agent@warp.dev> Co-authored-by: Warp <agent@warp.dev>

Description
Adds phase 2 of the Windows Warp Agent CLI release stack on top of #14444:
Windows artifact publication remains intentionally disabled in this stack.
Conversation: https://staging.warp.dev/conversation/7b2fa858-09f9-47dd-8819-277acd3fa779
Linked Issue
No linked issue.
ready-to-specorready-to-implement.Testing
./script/formatrepository-required workspace, GUI-default, and completer Clippy invocations with
-D warningsnative workflow run 30400009894 passed Windows package tests and exposed the missing Windows channel-config prerequisite; this PR now installs it for credentialed release jobs
credentialed non-publishing dev release passed real build, Azure signing, deterministic payload/symbol packaging, isolated launch, packaged ConPTY smoke, and workflow artifact upload: https://github.com/warpdotdev/warp-internal/actions/runs/30419349007
I have manually tested my changes locally with
./script/runAgent Mode
CHANGELOG-NONE