Skip to content

Build Windows Warp Agent CLI in dev releases - #14445

Open
kevinyang372 wants to merge 1 commit into
07-28-bundle_warp_agent_cli_for_windowsfrom
07-28-build_windows_warp_agent_cli_in_dev_releases
Open

Build Windows Warp Agent CLI in dev releases#14445
kevinyang372 wants to merge 1 commit into
07-28-bundle_warp_agent_cli_for_windowsfrom
07-28-build_windows_warp_agent_cli_in_dev_releases

Conversation

@kevinyang372

@kevinyang372 kevinyang372 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Description

Adds phase 2 of the Windows Warp Agent CLI release stack on top of #14444:

  • runs a dev-only Windows x64 TUI release job
  • builds the standalone CLI, signs the CLI and ConPTY executables with Azure Trusted Signing, and packages only after signing
  • inspects and launches the isolated package, then exercises packaged ConPTY with PowerShell
  • uploads workflow artifacts without publishing them to release storage
  • installs the private channel-config generator for credentialed Windows release builds
  • retries shell creation inside restrictive Windows job objects when explicit breakaway is denied

Windows artifact publication remains intentionally disabled in this stack.

Conversation: https://staging.warp.dev/conversation/7b2fa858-09f9-47dd-8819-277acd3fa779

Linked Issue

No linked issue.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • ./script/format

  • repository-required workspace, GUI-default, and completer Clippy invocations with -D warnings

  • native workflow run 30400009894 passed Windows package tests and exposed the missing Windows channel-config prerequisite; this PR now installs it for credentialed release jobs

  • credentialed non-publishing dev release passed real build, Azure signing, deterministic payload/symbol packaging, isolated launch, packaged ConPTY smoke, and workflow artifact upload: https://github.com/warpdotdev/warp-internal/actions/runs/30419349007

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

@cla-bot cla-bot Bot added the cla-signed label Jul 28, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinyang372
kevinyang372 force-pushed the 07-28-build_windows_warp_agent_cli_in_dev_releases branch 3 times, most recently from c0cec5e to 90f8877 Compare July 29, 2026 01:12
@kevinyang372
kevinyang372 force-pushed the 07-28-bundle_warp_agent_cli_for_windows branch from 58874da to 7870838 Compare July 29, 2026 01:12
@kevinyang372
kevinyang372 force-pushed the 07-28-build_windows_warp_agent_cli_in_dev_releases branch 2 times, most recently from 753b488 to 3982b28 Compare July 29, 2026 03:19
@kevinyang372
kevinyang372 marked this pull request as ready for review July 29, 2026 05:07
@oz-for-oss

oz-for-oss Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a dev-only Windows x64 TUI/Agent CLI release job, wires Windows channel-config installation into release dependency setup, adds package inspection and ConPTY smoke coverage, and retries Windows shell creation without breakaway when job-contained hosts deny it.

Concerns

  • No blocking concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@kevinyang372
kevinyang372 force-pushed the 07-28-bundle_warp_agent_cli_for_windows branch from 7870838 to fce90e9 Compare July 30, 2026 01:40
@kevinyang372
kevinyang372 force-pushed the 07-28-build_windows_warp_agent_cli_in_dev_releases branch from 3982b28 to 9af5dfb Compare July 30, 2026 01:41
@kevinyang372
kevinyang372 force-pushed the 07-28-build_windows_warp_agent_cli_in_dev_releases branch from 9af5dfb to 7fa5f45 Compare July 30, 2026 01:53
@kevinyang372
kevinyang372 force-pushed the 07-28-bundle_warp_agent_cli_for_windows branch from fce90e9 to 0d065f9 Compare July 30, 2026 01:53
kevinyang372 added a commit that referenced this pull request Jul 31, 2026
## Description
Add a dev-only Windows x64 release job for the Warp Agent CLI Inno
installer.

The job builds the real CLI, signs the CLI and Windows runtime payloads
with Azure Trusted Signing, signs the setup engine and uninstaller, and
uploads the installer and raw PDB as workflow artifacts. Inno signing
setup is shared with the existing Windows GUI release job.

Artifact publication remains intentionally disabled. This replaces
reference PR #14445 without modifying it.

Depends on #14475.

Implementation plan:
https://staging.warp.dev/drive/notebook/BI2TyxneCNDssiTUVIF0iK

## Linked Issue
- [ ] The linked issue is labeled `ready-to-spec` or
`ready-to-implement`.
- [ ] Where appropriate, screenshots or a short video of the
implementation are included below.

## Testing
- `./script/format`
- Repository-prescribed split Clippy checks
- `cargo check -p warp --lib`
- Release workflow validates the installer fixture, real signed build,
shared Inno signing setup, and installer/raw-PDB artifact output
- Credentialed non-publishing release validation will be linked after
this branch is remotely exercised

- [ ] I have manually tested my changes locally with `./script/run`

## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Warp <agent@warp.dev>

Co-authored-by: Warp <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant