Skip to content

Group 4 Contributions

Anmol Thapar edited this page Apr 20, 2021 · 34 revisions

This page contains a list of contributions by each Team Member.

Click one of the names below to quickly go to that Team Member:

Whole Team      Leon Chin      Reeve D'Cunha      Jiawei Ge     Tom Guernier     Daniel Hor      Maric Kim
Xiaobin Lin      Jennifer Lowe      Jaimee McLaughlan      Sky Nguyen      Siyu Qian     
Sreeniketh Raghavan      Justin Teo      Arjun Thakur      Anmol Thapar      Alan Thomas
Zheyuan Xiao      Seif Younes


Whole Team

  • PR review
  • Documentation
  • Issue approvals & creation of issues

Leon Chin

  • Fixed a bug to do with sessions being persisted in server memory even after the game has ended. The fix prevents the server from running out of memory from prolonged uptime
    • Added documentation about the new event handler host_room that was created as part of the bug-fix
  • Fixed bug dealing with initial countdown reaching -1

Reeve D'Cunha

  • Subteam co-ordinator
  • Implemented UI responsiveness throughout the app
  • Added UI improvements (dark theme, cohesiveness etc)
  • Added logic for the app to choose a random restaurant if there are multiple top choices
  • Various frontend refactoring and code cleanup
  • Pair-Programmed with sub-teammates to help them out with their tasks
  • Helped fix snapshot and jest issues
  • Helped maintain the Issue Tracker and documented issues with enough information for other members to complete with ease
  • Helped review PRs
  • Helped organise the team as a whole to make sure everything was well co-ordinated and everyone was on track at all times

Jiawei Ge

  • Fix the timer bug. [Guests' timer is different with Host's timer]
  • Fix the no result bug. [Error is thrown when no restaurant is liked]
  • Help fix test errors.
  • Minor code tidy up and refactor.

Tom Guernier

  • Fully implemented results page, adding the map, photo, rating and price (#267)
  • Code cleanup, including removing unused code related to the unimplemented cuisine field (#290)

Daniel Hor

  • Bug hunting
  • Implemented UI responsiveness throughout the app
    • results page, google map, result graph
  • Implemented UI redesign (dark theme, mobile responsiveness, standardised component set)
    • results page, popups, graphs, and map
  • Added logic to inform user in the case that no results are found in a search.
  • Commenting of Frontend components and pages

Maric Kim

  • Helped planning for the implementation of the max price filter
  • Added Restart button to the results page

Xiaobin Lin

  • Fix broken CD pipeline by resolving broken dependencies
  • Provide feedback to the user when they have voted by creating a responsive ribbon overlay

Jennifer Lowe

  • Done with Sky! Set an expiry on Session MongoDB documents (one week), so that we avoid running out of session ids. The motivation: we now persist session data, so we want to be careful about running out of session ids. We created a TTL index key in the database (this is auto-generated upon app restart).
  • Refactored MongoDB configuration out of the main backend index.js
  • Helped fix frontend snapshot tests
  • Added/fleshed out the integration tests for the backend sockets.

Jaimee McLaughlan

  • Done with Justin. Added a new feature where past players can enter their old lobby code to view results of the game they played, in case they forgot which restaurant won or need to check for runner up restaurants. Also ensures complete games can not be replayed.

Sky Nguyen

  • Done with Jennifer. Set an expiry on Session MongoDB documents (one week), so that we avoid running out of session ids. The motivation: we now persist session data, so we want to be careful about running out of session ids. We created a TTL index key in the database (this is auto-generated upon app restart).
  • Added/fleshed out the integration tests for the backend sockets.

Siyu Qian

  • Integrated the Google Place API with Price Filter
  • Minor code tidy up & Refactor

Sreeniketh Raghavan

  • Changed the styling and aesthetic of the preferences page to match the new theme
  • Worked on the lobby page restyling with Reeve
  • Fixed the low-res background image bug
  • Changed the Go button styling on the Join page and the Close button text for all pages

Justin Teo

  • Added new feature where past players can enter their old lobby code to view results of the game they played, in case they forgot which restaurant won or need to check for runner up restaurants. Done with Jaime.
  • Extracted out the publically viewable Google API key from index.html security threat. Frontend now calls a backend endpoint to retrieve the key, this way it is hidden from view to the public on GitHub.
  • Updated Readme, env.example and Wiki to reflect this change.
  • Restyled the results page with user experience in mind.

Arjun Thakur

  • Resized Lobby Page

Anmol Thapar

  • Added mobile responsiveness to the landing page and lobby join
  • add bootstrap and UI changes to landing page and lobby join
  • help button and dialogue redo ui

Alan Thomas

  • Fixed bug related to countdown/timer
  • Added functionality to allow swiping of the cards like tinder.

Zheyuan Xiao

  • Fixed countdown/timer frontend bug
  • Fixed bug related to a button

Seif Younes

  • Added .env.example file for backend, along with comments to describe the purpose of each environment variable
  • Helped in planning work and reviewing PRs for max price filter, and handling of edge case where no restaurants are picked

Clone this wiki locally