RFC 222: Support BigInts in numerical assertion functions and output #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
changed the title
This was referenced Apr 21, 2025
jgraham
approved these changes
Apr 22, 2025
|
|
||
| ## Risks | ||
|
|
||
| Any change to `testharness.js` can affect error stacks. This could cause a mismatch in "expectation" files maintained by implementations and failures in their CIs, requiring baseline updates. This is probably unavoidable maintenance burden for such tests. Here is one example in a prototype update, in the Chromium repository: https://chromium-review.googlesource.com/c/chromium/src/+/6351358/6/third_party/blink/web_tests/external/wpt/html/infrastructure/safe-passing-of-structured-data/structured-cloning-error-stack-optional.sub.window-expected.txt |
Contributor
There was a problem hiding this comment.
I note that although some vendors do indeed do this, the console output or assert messages have never been considered part of the stable API offered by wpt.
Ms2ger
approved these changes
Apr 22, 2025
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Thanks! This seems sensible enough to me.
Contributor
Author
|
So far as I can tell by the RFC Process, this has review approvals and no substantive disagreement 1 week after the first approval, is this now accepted and can it be merged? |
Member
|
Technically tomorrow will be one week after the first approval, and I plan to merge this if nobody else comments until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.