Fix test_testfiles.py to use new manifest format#21580
Merged
Merged
Conversation
wpt-pr-bot
requested review from
Hexcles,
KyleJu,
LukeZielinski,
jgraham and
jugglinmike
February 4, 2020 19:29
Contributor
Author
|
So this is sort of concerning. Surely this test should have failed parsing the manifest on all platforms, given that it was trying to interpret 'a/b/c/foo-crash.html' as a filename? (After the trie switch). Instead, it passed fine on TaskCluster and only failed on Windows thanks to different file-path separators. |
Hexcles
approved these changes
Feb 4, 2020
sideshowbarker
added a commit
that referenced
this pull request
Feb 6, 2020
This reverts commit e5b8dd0.
sideshowbarker
added a commit
that referenced
this pull request
Feb 6, 2020
…and subsequent changes that depended on it The changes to manifest generation broke the web-based runner. * Revert "Major new manifest version (v8): path trie edition" This reverts commit 31c0f5e. * Revert "Fix test_testfiles.py to use new manifest format (#21580)" This reverts commit e5b8dd0. * Revert "Bump to version 8 (#21569)" This reverts commit 4e8d4aa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.